Bug Tracker

Modify

Ticket #7147 (closed bug: duplicate)

Opened 3 years ago

Last modified 3 years ago

1.4.3 RC1 breaks jQuery UI dialog

Reported by: jagid Owned by: john
Priority: blocker Milestone: 1.4.3
Component: traversing Version: 1.4.2
Keywords: Cc:
Blocking: Blocked by:

Description

I know that there is a jQuery UI element to this issue but as the below code works with 1.4.2 a change in 1.4.3 is causing the issue. With the below code the dialog does not display unless the buttons line is removed.

<div id="testdiv">Test content<div>

<link href=" http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.4/themes/smoothness/jquery-ui.css" rel="stylesheet" type="text/css" /> <script type="text/javascript" src=" http://code.jquery.com/jquery-1.4.3rc1.js"></script> <script type="text/javascript" src=" http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.4/jquery-ui.min.js"></script> <script type="text/javascript">

$(document).ready(function () {

$("#testdiv").dialog({

buttons: { "OK": function () { alert($(this).html()); }}

});

});

</script>

Change History

comment:1 Changed 3 years ago by snover

  • Owner set to snover
  • Priority changed from undecided to blocker
  • Status changed from new to assigned

Issue only occurs with buttons property active. Looks like jQuery 1.4.3 checks for properties on cur in .closest but cur is not always defined, so it generates an error. Line 4193 needs a !cur in the conditional.  Live test case

comment:2 Changed 3 years ago by snover

  • need changed from Review to Commit
  • Owner changed from snover to john
  • Status changed from assigned to new
  • Component changed from unfiled to traversing

comment:3 Changed 3 years ago by john

  • Status changed from new to closed
  • Resolution set to duplicate

Duplicate of #7142.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.