Bug Tracker

Modify ↓

Ticket #7142 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Closest() is broken in 1.4.3

Reported by: lcr Owned by:
Priority: blocker Milestone: 1.4.3
Component: traversing Version: 1.4.2
Keywords: closest broken Cc:
Blocking: Blocked by:

Description

The closest method ends in the following loop:

for ( i = 0, l = this.length; i < l; i++ ) {

cur = this[i];

while ( cur ) {

if ( pos ? pos.index(cur) > -1 :

jQuery.find.matchesSelector(cur, selectors) ) {

ret.push( cur ); break;

} else {

cur = r.parentNode;

if (!cur.ownerDocument
cur === context ) {

break;

}

}

}

} the following line:

if (!cur.ownerDocument
cur === context ) {

will not work if r.parentNode return null, thus it should be changed to

if (cur && !cur.ownerDocument
cur === context ) {

Best regards, Laurent

Change History

comment:1 Changed 3 years ago by john

  • Status changed from new to closed
  • Resolution set to fixed

Fixed  http://github.com/jquery/jquery/commit/385ca2aa899d2ed953d9e18c95387e72e330b42c

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.