"handle" won't work as a key for .data() method

[itachi]

--- to reproduce, evaluate:

/* any jQuery el */

var $el = $(document)

/* set "handle" to anything but a function */

$el.data("handle", {}))

/* this fails, see line 1850 where jQuery.trigger() function assumes that jQuery.data( elem, "handle" ) is a function */

$el.data("handle")

--- expected: "handle" keyword work or is marked invalid in docs

[dmethvin]

Good point, perhaps it would be a good idea for jQuery to use a leading $ for its data names to avoid conflicts.

[dmethvin]

Also used internally:

__className__
handle
events
_change_data
lastToggle
events
olddisplay

[snover]

We need to stop polluting the data objects with internal data. 1.4.3 also adds __events__ as a polluting key.

[snover]

Retargeting to 1.5.

[cobexer]

what about using jQuery.expando + "_events",...

this would remove all collision possibilities.

however it would also pollute the display in FireQuery (Firebug addon)

maybe reserve "jQuery." as prefix a user may not use

[iliakan]

It seems sane to have $ as prefix for all jquery native stuff, or even $, like: "" as hidden library stuff and "$" pointing that it is jquery library stuff.

[rwaldron]

#7651 is a duplicate of this ticket.

[gnarf]

Replying to iliakan:

It seems sane to have $ as prefix for all jquery native stuff, or even $, like: "" as hidden library stuff and "$" pointing that it is jquery library stuff.

I kinda like that idea... .data('$')['events'] or .data('$events') either seems less polluting for the internals. I wonder how many people are using .data('events') or other internal keys for their own code/purposes though. Either suggestion would be easy enough to compat mode, making the .data strip the $ off the argument.

[snover]

 pull request i forgot to put this here.

[Colin Snover]

Merge in data_nocollide branch. Fixes #6968, improves unit testing framework checks for leaky stuff.

Changeset: e78d3a7e2d47e9796f87c18b76f8178b0bee42c5