Dom Manipulation fails if added text happens to match Object method

[cscott]

When you try to add the text "hasOwnProperty", for example, the dom manipulation cache "finds" hasOwnProperty and tries to add a *function* to the DOM. This also holds for any other methods of Object.

The attached patch fixes the problem, by using hasOwnProperty to ensure that the cache match isn't actually an Object method. (We also need to ensure that hasOwnProperty isn't cacheable.)

[cscott]

Patch to fix the problem.

[cscott]

Patch also in github as:  http://github.com/cscott/jquery/commit/7dbc01ae248b1abd8751fdff1ec0891b6ba1d5c6

[rwaldron]

Please provide a reduced jsFiddle test case, thanks!

[dmethvin]

 http://jsfiddle.net/dmethvin/SdCg8/6/ Test case

[dmethvin]

snover suggested we just not cache strings that have no html, that would fix the problem with a simple test for '<'.

[snover]

Beyond just not testing for strings with no HTML, I suggested to only cache strings where the first character is a <.

[dmethvin]

Fix:  https://github.com/jquery/jquery/pull/146

[Dave Methvin]

Don't cache non-html strings in buildFragment to avoid possible collision with the names of Object methods like toString. Also makes the unit tests 0.5% to 8% faster. Fixes #6779.

Changeset: 5fd21fc02bda43d4e31bcf2d5b55b918a9190a7f

[Dave Methvin]

Don't cache non-html strings in buildFragment to avoid possible collision with the names of Object methods like toString. Also makes the unit tests 0.5% to 8% faster. Fixes #6779.

Changeset: 5fd21fc02bda43d4e31bcf2d5b55b918a9190a7f