Side navigation
#6743 closed bug (fixed)
Opened June 29, 2010 09:10AM UTC
Closed October 22, 2011 08:04PM UTC
Last modified March 08, 2012 10:51PM UTC
map enctype to encoding, depending on browser
| Reported by: | Ollie2893 | Owned by: | timmywil |
|---|---|---|---|
| Priority: | low | Milestone: | 1.7 |
| Component: | attributes | Version: | 1.5.2 |
| Keywords: | attr enctype encoding | Cc: | SlexAxton |
| Blocked by: | Blocking: |
Description
I cannot be the first person to raise this request but I cannot find a ticket anywhere. In the .attr(), please harmonize the handling of "enctype" across browsers. For IE this means that jQuery should map "enctype" to "encoding". I figured this out at the end of a frustrating multi-hour debugging session. I really rely on jQuery to take care of these irritating small idiosyncrasies between browsers (lest my code be polluted by browser-specific hacks). Thank you.
Attachments (0)
Change History (10)
Changed June 30, 2010 12:17AM UTC by comment:1
| component: | unfiled → attributes |
|---|
Changed November 03, 2010 03:21AM UTC by comment:2
| cc: | → SlexAxton |
|---|---|
| keywords: | → attr enctype encoding |
| priority: | → low |
| status: | new → open |
| type: | enhancement → bug |
This seems legit. Prototype does this translation as well. I think it could be done with a pretty simple feature test.
I created a possible solution in a jsfiddle. http://jsfiddle.net/SlexAxton/59znU/
I'll pull a patch sometime soon, unless someone thinks it's a terrible idea?
I usually err on the side of 'this is an enhancement' - but I'd say jQuery should be handling a cross-browser issue like this, so I'll land this as a bug fix (just not the regression kind).
Related Prototype ticket:
Changed November 03, 2010 03:29AM UTC by comment:3
| milestone: | 1.4.3 → 1.5 |
|---|
Moving to appropriate release
Changed February 06, 2011 01:36PM UTC by comment:5
| milestone: | → 1.5.1 |
|---|---|
| owner: | → jitter |
| status: | open → assigned |
| version: | 1.4.2 → 1.5 |
Changed April 02, 2011 01:51AM UTC by comment:6
Any updates on this one? Did we decide we want to add the fix?
Changed April 15, 2011 05:11AM UTC by comment:7
| milestone: | 1.5.1 → 1.next |
|---|---|
| version: | 1.5 → 1.5.2 |
Changed July 12, 2011 06:49PM UTC by comment:8
| owner: | jitter → timmywil |
|---|
Yeah, we should tackle this - as discussed in the bug triage meeting.
Changed October 17, 2011 08:27PM UTC by comment:9
| milestone: | 1.next → 1.7 |
|---|
Changed October 22, 2011 08:04PM UTC by comment:10
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Support setting both the enctype attribute and property (encoding in IE6/7). Fixes #6743.
Changeset: c51b29477e2884fc28cfe4de5b64308177678262