Skip to main content

Bug Tracker

Side navigation

#6743 closed bug (fixed)

Opened June 29, 2010 09:10AM UTC

Closed October 22, 2011 08:04PM UTC

Last modified March 08, 2012 10:51PM UTC

map enctype to encoding, depending on browser

Reported by: Ollie2893 Owned by: timmywil
Priority: low Milestone: 1.7
Component: attributes Version: 1.5.2
Keywords: attr enctype encoding Cc: SlexAxton
Blocked by: Blocking:
Description

I cannot be the first person to raise this request but I cannot find a ticket anywhere. In the .attr(), please harmonize the handling of "enctype" across browsers. For IE this means that jQuery should map "enctype" to "encoding". I figured this out at the end of a frustrating multi-hour debugging session. I really rely on jQuery to take care of these irritating small idiosyncrasies between browsers (lest my code be polluted by browser-specific hacks). Thank you.

Attachments (0)
Change History (10)

Changed June 30, 2010 12:17AM UTC by dmethvin comment:1

component: unfiledattributes

Changed November 03, 2010 03:21AM UTC by SlexAxton comment:2

cc: → SlexAxton
keywords: → attr enctype encoding
priority: → low
status: newopen
type: enhancementbug

This seems legit. Prototype does this translation as well. I think it could be done with a pretty simple feature test.

I created a possible solution in a jsfiddle. http://jsfiddle.net/SlexAxton/59znU/

I'll pull a patch sometime soon, unless someone thinks it's a terrible idea?

I usually err on the side of 'this is an enhancement' - but I'd say jQuery should be handling a cross-browser issue like this, so I'll land this as a bug fix (just not the regression kind).

Related Prototype ticket:

https://prototype.lighthouseapp.com/projects/8886/tickets/658-writeattribute-doesnt-work-properly-with-enctypeencoding

Changed November 03, 2010 03:29AM UTC by SlexAxton comment:3

milestone: 1.4.31.5

Moving to appropriate release

Changed February 06, 2011 01:36PM UTC by jitter comment:4

#8186 is a duplicate of this ticket.

Changed February 06, 2011 01:36PM UTC by jitter comment:5

milestone: → 1.5.1
owner: → jitter
status: openassigned
version: 1.4.21.5

Changed April 02, 2011 01:51AM UTC by timmywil comment:6

Any updates on this one? Did we decide we want to add the fix?

Changed April 15, 2011 05:11AM UTC by timmywil comment:7

milestone: 1.5.11.next
version: 1.51.5.2

Changed July 12, 2011 06:49PM UTC by john comment:8

owner: jittertimmywil

Yeah, we should tackle this - as discussed in the bug triage meeting.

Changed October 17, 2011 08:27PM UTC by timmywil comment:9

milestone: 1.next1.7

Changed October 22, 2011 08:04PM UTC by timmywil comment:10

resolution: → fixed
status: assignedclosed

Support setting both the enctype attribute and property (encoding in IE6/7). Fixes #6743.

Changeset: c51b29477e2884fc28cfe4de5b64308177678262