Skip to main content

Bug Tracker

Side navigation

#5479 closed enhancement (fixed)

Opened November 10, 2009 02:09AM UTC

Closed September 20, 2011 01:07AM UTC

Last modified March 08, 2012 03:37PM UTC

removeAttr: remove multiple attributes

Reported by: scottgonzalez Owned by: rwaldron
Priority: low Milestone: 1.7
Component: attributes Version: 1.5.2
Keywords: 1.7-discuss Cc:
Blocked by: Blocking:
Description

It would be nice if removeAttr() accepted multiple attributes. This could work exactly like removeClass() does.

Attachments (0)
Change History (29)

Changed June 13, 2010 06:25PM UTC by dmethvin comment:1

component: unfiledattributes

Changed November 01, 2010 09:37PM UTC by rwaldron comment:2

keywords: → needsreview
milestone: → 1.5
owner: → rwaldron
priority: majorlow
status: newassigned

Good suggestion

Changed November 05, 2010 02:35AM UTC by dmethvin comment:3

keywords: needsreview

Changed December 01, 2010 02:09AM UTC by jitter comment:4

#7649 is a duplicate of this ticket.

Changed December 01, 2010 02:10AM UTC by jitter comment:5

version: 1.3.21.4.4

Changed December 04, 2010 02:38PM UTC by jitter comment:6

Changed February 10, 2011 03:42AM UTC by petersendidit comment:7

Whats the reason this isn't getting landed?

Changed March 23, 2011 09:07PM UTC by timmywil comment:8

Would we like to add this to attrhooks?

Changed April 15, 2011 03:16AM UTC by timmywil comment:9

milestone: → 1.7
version: 1.4.41.5.2

My guess is this will probably land with the enhancement on removeData in 1.7: #7323

Changed April 15, 2011 03:41AM UTC by timmywil comment:10

#8221 is a duplicate of this ticket.

Changed April 16, 2011 08:59PM UTC by john comment:11

milestone: 1.71.next

We should consider this for 1.7.

Changed May 22, 2011 07:27PM UTC by john comment:12

keywords: → 1.7-discuss

Nominating ticket for 1.7 discussion.

Changed May 22, 2011 10:26PM UTC by rwaldron comment:13

+1, Consistent with #7323

Changed May 22, 2011 11:51PM UTC by jaubourg comment:14

+1, yes to API Symmetry

Changed May 23, 2011 01:51AM UTC by ajpiano comment:15

+1, Deffo

Changed May 23, 2011 02:51AM UTC by timmywil comment:16

+1, Yes, but possibly with an access-like function to dry up similar functions.

Changed May 23, 2011 03:26PM UTC by danheberden comment:17

+1

Changed May 23, 2011 09:12PM UTC by dmethvin comment:18

+1, An access-like function would be good here.

Changed June 03, 2011 01:17PM UTC by john comment:19

+1, Obvious missing API.

Changed June 03, 2011 02:16PM UTC by scottgonzalez comment:20

+1, obviously, I filed the ticket :-)

Changed June 04, 2011 10:19PM UTC by addyosmani comment:21

+1

Changed June 06, 2011 03:38PM UTC by jzaefferer comment:22

+1, one more feature I could take out of my validation plugin

Changed June 06, 2011 03:49PM UTC by cowboy comment:23

+1, I like it, but should we do .removeAttr("foo bar") or .removeAttr("foo", "bar")?

Changed June 06, 2011 03:56PM UTC by scottgonzalez comment:24

Replying to [comment:23 cowboy]:

+1, I like it, but should we do .removeAttr("foo bar") or .removeAttr("foo", "bar")?

"foo bar", consistent with everything

Changed July 11, 2011 07:13PM UTC by ajpiano comment:25

milestone: 1.next1.7

Changed August 24, 2011 06:09PM UTC by Leon Sorokin <leeoniya@gmail.com> comment:26

Changed August 24, 2011 06:56PM UTC by rwaldron comment:27

At this point, whatever, the first is out of date, but that can be fixed. The second is up-to-date, but has no tests and hasn't responded or updated with the tests I provided: ( https://github.com/rwldrn/jquery/commit/bece3a7ab2ae26947634ad57fb08390d55d209fc )

Changed September 07, 2011 09:11PM UTC by rwaldron comment:28

Since no one has responded to my last comment about combining the efforts, I've gone ahead and done so myself.

Current: https://github.com/jquery/jquery/pull/492/

Changed September 20, 2011 01:07AM UTC by Rick Waldron comment:29

resolution: → fixed
status: assignedclosed

Landing pull request 492. 1.7 Remove multiple attributes (Symmetry with removeClass) Combines patches submitted by leeoniya, zertosh and my own tests. Fixes #5479.

More Details:

Changeset: ca4133cc3fb4202d08de0d9e9d05e2442be63653