#4693 closed bug (worksforme)

Opened May 28, 2009 04:38PM UTC

Closed April 17, 2011 06:10PM UTC

Last modified September 18, 2013 04:06PM UTC

Memory leak with framesets in modal dialog

Reported by:	dberthia	Owned by:
Priority:	low	Milestone:
Component:	event	Version:	1.3.2
Keywords:	ie memory leak	Cc:
Blocked by:		Blocking:

Description

In IE6/7, jQuery 1.3.2 introduces a browser memory leak when opening a modal dialog window that contains a frameset. The leak is made worse if there are nested framesets in the popup window, and pages within the frameset include jQuery. See attached files to reproduce the problem.

Attachments (1)

Leak.zip (21.3 KB) - added by dberthia May 28, 2009 04:39PM UTC.

Unzip and launch index.htm in IE6. Use Task Manager to monitor as you open/close the popup window.

Change History (14)

Changed October 14, 2009 01:54AM UTC by dmethvin comment:1

milestone:	1.3.2 → 1.3.3
priority:	critical → major

Changed October 28, 2009 05:27PM UTC by vesech comment:2

Anxiously awaiting the outcome of this.

Changed October 28, 2009 05:34PM UTC by dberthia comment:3

I'm heartened to see some activity on this. We had to remove jQuery from our modal dialogs because of this, which obviously seriously restricts us from a development standpoint.

Changed November 11, 2009 08:18PM UTC by john comment:4

component:	unfilled → core

Changed March 18, 2010 08:21PM UTC by dberthia comment:5

I'm now disheartened so see 1.4 roll out and still no activity on this.

Changed July 29, 2010 10:14AM UTC by re076 comment:6

Try this fix to 1.4.2

add to line 67:

FSP change

DOMContentUnLoaded,

add to line 756:

FSP change

DOMContentUnLoaded = function() {

Original

for ( var id in jQuery.cache ) {

if ( jQuery.cache[ id ].handle ) {

Try/Catch is to handle iframes being unloaded, see #4280

try {

jQuery.event.remove( jQuery.cache[ id ].handle.elem );

}

catch(e) {}

}

FSP extension

window.detachEvent( "onload", jQuery.ready );

window.detachEvent( "onunload", DOMContentUnLoaded );

window.jQuery = window.$ = jQuery = null;

};

FSP change end

change line 2627:

if ( window.attachEvent && !window.addEventListener ) {

//FSP change

window.attachEvent("onunload", DOMContentUnLoaded );

}

Changed October 27, 2010 06:18PM UTC by SlexAxton comment:7

milestone:	1.4 → 1.5
priority:	major → low
status:	new → open

Seems to still exist in 1.4.x - marking as valid.

Changed April 17, 2011 06:10PM UTC by john comment:8

component:	core → event
resolution:	→ worksforme
status:	open → closed

I believe that this has been resolved. Please re-open if that is no longer the case.

Changed May 29, 2011 08:00AM UTC by alexgalp comment:9

I'm checked the attached test case on ie7 and 6 with jQuery 1.6.1 and the leak is still occurs.

Changed May 29, 2011 01:33PM UTC by anonymous comment:10

The bug still happens! is it a dead end?

Changed May 30, 2011 03:36PM UTC by rwaldron comment:11

#9462 is a duplicate of this ticket.

Changed May 31, 2011 09:09PM UTC by rwaldron comment:12

#9471 is a duplicate of this ticket.

Changed May 31, 2011 09:17PM UTC by r_ramasamy@servicespan.net comment:13

Replying to [comment:12 rwaldron]: