Bug Tracker

#462 closed bug (fixed)

Opened December 02, 2006 06:42PM UTC

Closed January 02, 2007 07:07AM UTC

Last modified June 21, 2007 05:09AM UTC

var are missing in plugins/interface/iutil.js + patch + test

Reported by: toggg Owned by: stefan
Priority: minor Milestone: 1.1a
Component: interface Version: 1.1a
Keywords: Cc:
Blocked by: Blocking:
Description

I noticed several variables which should be local but not declared as such using "var".

It only *may* become a problem.

Modified iutil.js and patch for it as by [503] follow.

As, I'm unsure and it is a necessity, I join some draft, not achieved, test.

I look forward to complete it with some ok().

Not sure about the getClient() thing...

Also, there's nothing for getPointer(), traverseDOM() and purgeEvents() as they are not directly feasable with the current simple test scheme. Same for the second parameter "toInteger" when it applies. I'll prepare something more complete.

Attachments (1)
  • iutil.js.patch (6.4 KB) - added by toggg December 02, 2006 06:45PM UTC.

    interface/iutil.js patch for #462

Change History (5)

Changed December 02, 2006 07:06PM UTC by toggg comment:1

Files are there:

Changed December 04, 2006 10:55AM UTC by toggg comment:2

A more complete and compliant test

Changed December 07, 2006 03:52PM UTC by toggg comment:3

I refactored the above test.

Case the test fails, a button should show to display the diffs.

Expected values are FF based. So far we can see , only IE fails.

Changed December 09, 2006 05:49PM UTC by anonymous comment:4

ie5.5: 5 fail (1-5)

ie6.0: 3 fail (1,2,5)

ie5.0: doesn't run (haven't investigated)

opera9.00: 3 fail (1,2,5)

konq3.55: pass

ff2.0: pass

note: ies running through wine

Changed January 02, 2007 07:07AM UTC by stefan comment:5

resolution: → fixed
status: new → closed