Bug Tracker

Modify ↓

Ticket #462 (closed bug: fixed)

Opened 6 years ago

Last modified 6 years ago

var are missing in plugins/interface/iutil.js + patch + test

Reported by: toggg Owned by: stefan
Priority: minor Milestone: 1.1a
Component: interface Version: 1.1a
Keywords: Cc:
Blocking: Blocked by:

Description

I noticed several variables which should be local but not declared as such using "var".

It only *may* become a problem.

Modified iutil.js and patch for it as by [503] follow.

As, I'm unsure and it is a necessity, I join some draft, not achieved, test.

I look forward to complete it with some ok().

Not sure about the getClient() thing...

Also, there's nothing for getPointer(), traverseDOM() and purgeEvents() as they are not directly feasable with the current simple test scheme. Same for the second parameter "toInteger" when it applies. I'll prepare something more complete.

Attachments

iutil.js.patch Download (6.4 KB) - added by toggg 6 years ago.
interface/iutil.js patch for #462

Change History

Changed 6 years ago by toggg

interface/iutil.js patch for #462

comment:3 Changed 6 years ago by toggg

I refactored the above test.

Case the test fails, a button should show to display the diffs.

Expected values are FF based. So far we can see , only IE fails.

comment:4 Changed 6 years ago by anonymous

ie5.5: 5 fail (1-5)
ie6.0: 3 fail (1,2,5)
ie5.0: doesn't run (haven't investigated)
opera9.00: 3 fail (1,2,5)
konq3.55: pass
ff2.0: pass

note: ies running through wine

comment:5 Changed 6 years ago by stefan

  • Status changed from new to closed
  • Resolution set to fixed

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.