insertAfter, insertBefore, etc do not work when destination is original element

[XASD]

If you do $("#x").insertBefore("#x") element removed entirely from DOM.It seems somehow related to using dom fragments. Version 1.2.6 of jquery work as expected(preserve element on the same place)+it has "reverse" parameter for domManip() used in "after" method,but 1.3.1 does not have one.Is there logical error here?

Thanks.

[XASD]

Sorry,I mean $("#x").insertAfter("#x") don't know about insertBefore.

[dmethvin]

I see what you mean about the documentFragment stuff. Since jQuery.domManip passes in a fragment, jQuery.clean moves #x to the fragment. Later when it gets to the callback in jQuery.after, the original parentNode is gone.

So how did you come up with this case? Is there some more complex code where you end up trying to insert a node after itself?

[XASD]

<ul id="m">
	<li class="hl">
		<div>c1</div>
		h1
	</li>
	<li>
		<div>c2</div>
		h2
	</li>
</ul>

$("#m div").insertAfter("#m li:first-child div:last-child");//combine in 1

Thanks.

[XASD]

1.3.2 still not resolved.

Regards.

[katbailey]

Just wanted to report that this same issue is causing a problem in Drupal's tabledrag functionality, though in our case it's insertBefore - here's a link to the issue on drupal.org:  http://drupal.org/node/350275

[XASD]

JQuery 1.4.2 bug is still there.

[snover]

Could you please confirm this bug still exists using the jQuery 0 GIT version of jQuery on  jsFiddle? If it does not, please provide a link to the testcase.

[jitter]

Confirmed in jQuery 0 git (as of c9c9057c4d4097767ca1 / 2010-12-13)

 test case

[ajpiano]

Confirmed in bug triage, dropping priority to low.

[john]

#7639 is a duplicate of this ticket.

[pbramos]

I'm going to look at this. Here's a fiddle using the above example:

 http://jsfiddle.net/pbramos/gZ7vB/

[pbramos]

I've got a fix for this that is passing my unit tests. I need to expand my tests a bit to cover all the cases.

[pbramos]

pull request:  https://github.com/jquery/jquery/pull/1033

[pbramos]

new pull request:  https://github.com/jquery/jquery/pull/1047

[pbramos]

aaaaaaaand another pull request:  https://github.com/jquery/jquery/pull/1068

:)

[Paul Ramos]

Fix #4087. insertAfter, insertBefore, etc do not work if origin and destination are same element. Close gh-1068.

Changeset: f12611feb43adb2b014eb2183db0713451746aff