Skip to main content

Bug Tracker

Side navigation

#3946 closed bug (fixed)

Opened January 21, 2009 11:57PM UTC

Closed October 03, 2010 01:48AM UTC

Some UI effects fail in 1.3

Reported by: kbwood Owned by:
Priority: minor Milestone: 1.3.1
Component: effects Version: 1.3
Keywords: Cc:
Blocked by: Blocking:
Description

In upgrading to 1.3 I noted that several of the UI effects (such as bounce and fold) no longer work correctly. After some testing I noted the following combinations:

1.2.6 and UI 1.5.3 - works

1.2.6 and UI 1.6rc5 - works

1.3 and UI 1.5.3 - doesn't work

1.3 and UI 1.6rc5 - doesn't work

Thus there has been some change between 1.2.6 and 1.3 that has broken these animations. The animation seems to stop half way through without raising an apparent error. This leaves the animated division in a non-displayable state.

Attachments (1)
  • animtest.html (1.5 KB) - added by kbwood January 21, 2009 11:58PM UTC.

    Testing harness with datepicker and animations

Change History (6)

Changed January 22, 2009 12:00AM UTC by kbwood comment:1

description: In upgrading to 1.3 I noted that several of the UI effects (such as bounce and fold) no longer work correctly. After some testing I noted the following combinations: \ \ 1.2.6 and UI 1.5.3 - works \ 1.2.6 and UI 1.6rc5 - works \ 1.3 and UI 1.5.3 - doesn't work \ 1.3 and UI 1.6rc5 - doesn't work \ \ Thus there has been some change between 1.2.6 and 1.3 that has broken these animations. The animation seems to stop half way through without raising an apparent error. This leaves the animated division in a non-displayable state.In upgrading to 1.3 I noted that several of the UI effects (such as bounce and fold) no longer work correctly. After some testing I noted the following combinations: \ \ 1.2.6 and UI 1.5.3 - works \ \ 1.2.6 and UI 1.6rc5 - works \ \ 1.3 and UI 1.5.3 - doesn't work \ \ 1.3 and UI 1.6rc5 - doesn't work \ \ Thus there has been some change between 1.2.6 and 1.3 that has broken these animations. The animation seems to stop half way through without raising an apparent error. This leaves the animated division in a non-displayable state.

Changed January 22, 2009 10:40PM UTC by kbwood comment:2

I've traced the problem to the speed function. When this is passed a speed value that is NaN it passes that through to the animation. This is because typeof (NaN) evaluates to 'number', which it isn't. So I think the test should be:

opt.duration = jQuery.fx.off ? 0 :

typeof opt.duration === "number" && !isNaN(opt.duration) ? opt.duration :

jQuery.fx.speeds[opt.duration] || jQuery.fx.speeds._default;

Changed January 23, 2009 01:28AM UTC by kbwood comment:3

There should be two vertical bars between the two values on the last line of code - they don't seem to show up!

Changed January 29, 2009 07:56PM UTC by scottgonzalez comment:4

This has been fixed in UI, see UI #3912.

Changed August 07, 2009 05:20PM UTC by dmethvin comment:5

component: unfilledfx

Changed October 03, 2010 01:48AM UTC by dmethvin comment:6

resolution: → fixed
status: newclosed

Fixed in UI.