Bug Tracker

Modify

Ticket #2288 (closed enhancement: wontfix)

Opened 6 years ago

Last modified 4 years ago

Ease of use enhancement for .show("slow")/.hide("slow")

Reported by: DiscoNova Owned by:
Priority: minor Milestone: 1.2.3
Component: effects Version: 1.2.2
Keywords: Cc:
Blocking: Blocked by:

Description

As per ticket #2041, it's impossible to use the "speed enabled" show/hide -functions on table-rows (and actually a few other elements whose native display-mode is not "block"), why even offer the possibility of shooting yourself in the foot? When a developer erroneously attempts to do something like that, why not just silently disallow it; a change could be made (for example) by changing this:

  show: function(speed,callback){
    return speed ?


...


  hide: function(speed,callback){
    return speed ?

...into this:

  show: function(speed,callback){
    return !this.is("tr,td,th") && speed ?


...


  hide: function(speed,callback){
    return !this.is("tr,td,th") && speed ?

The reason for this suggestion is that when the display-mode is changed from the native ("table-row" for TR, "table-cell" for TD, etc.) into "block", there are some unwanted side-effects in the rendering engines that could propably cause some mayhem in the long run.

Change History

comment:1 Changed 5 years ago by dantman

That's a pretty bad test right there. I've seen plenty of css hack cases where tables were converted into something else with css (even though they are a tr for accessibility, they use other displays when css is enabled) and other things that were converted into tables.

If anything is going to be tested it should probably be the actual display type.

comment:2 Changed 4 years ago by snover

  • Status changed from new to closed
  • Resolution set to wontfix

A patch has been introduced to allow use of show/hide with tables. This would never be the correct solution anyway.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.