Bug Tracker

#1449 closed bug (fixed)

Opened July 31, 2007 09:08PM UTC

Closed August 19, 2007 12:08AM UTC

parent method return duplicate elements

Reported by: blairmitchelmore Owned by:
Priority: minor Milestone: 1.1.4
Component: core Version: 1.1.3
Keywords: Cc:
Blocked by: Blocking:
Description

When you have multiple elements from the same parent elements in a jQuery array and then call parent, the resultant jQuery array contains multiple references to the same element.

Test case found at http://jquery.offput.ca/tests/parent.php

The page will alert '6' and it should alert '1'

Attachments (1)
  • 1449.diff (0.3 KB) - added by blairmitchelmore August 02, 2007 06:04PM UTC.

    Fix for #1449

Change History (2)

Changed August 02, 2007 05:53PM UTC by blairmitchel comment:1

I've fixed the bug (if it is a bug and not a "feature") but simply calling jQuery.unique inside the .parent() method.

                var ret = jQuery.map(this,n);
                if ( a && typeof a == "string" )
                        ret = jQuery.multiFilter(a,ret);
-               return this.pushStack( ret );
+               return this.pushStack( jQuery.unique(ret) );
        };
 });

I don't see any major consequences from this and it would be an easy patch for jQuery core. (Of course you could also patch pushStack to ensure things are unique, but that could be overkill.)

Changed August 19, 2007 12:08AM UTC by john comment:2

resolution: → fixed
status: new → closed

Fixed in SVN rev [2769].