Bug Tracker

#14313 closed bug (fixed)

Opened August 29, 2013 02:41AM UTC

Closed September 03, 2013 06:05AM UTC

Last modified January 10, 2014 05:39PM UTC

Optimize jQuery.merge for size

Reported by: me@ameyms.com Owned by: me@ameyms.com
Priority: low Milestone: 2.1
Component: core Version: 2.0.3
Keywords: Cc:
Blocked by: Blocking:
Description
  • Use 
    +
    operator instead of 
    typeof === "number"
  • Eliminate oldIE specific 
    else
    condition
Attachments (0)
Change History (9)

Changed September 02, 2013 01:37AM UTC by timmywil comment:1

component: unfiled → core
priority: undecided → low
status: new → open

Related: https://github.com/jquery/jquery/pull/1344

Changed September 02, 2013 01:38AM UTC by timmywil comment:2

owner: → me@ameyms.com
status: open → assigned

Changed September 03, 2013 06:05AM UTC by Amey Sakhadeo comment:3

resolution: → fixed
status: assigned → closed

Fix #14313: Optimize jQuery.merge for size. Close gh-1344.

Changeset: c75c9a8ebb5d2483daa68bec799e0d770083a811

Changed September 03, 2013 06:05AM UTC by Richard Gibson comment:4

Ref #14313: Further code and test improvements

Changeset: f66d53c85643e703a8e37d9ca9375dd386a60cda

Changed September 12, 2013 08:46PM UTC by Richard Gibson comment:5

Ref #14313: NaN detection. Close gh-1352.

(cherry picked from commit 0bc0a69026ce4c1ac570a729d3c975a4a55d0ff4)

Changeset: 68213f20bb5d5426f99bafde028ecab601a9d105

Changed September 20, 2013 12:08AM UTC by dmethvin comment:6

milestone: None → 2.1

Changed October 24, 2013 06:50AM UTC by anonymous comment:7

http://jsperf.com/typeof-number-vs-unary-plus/5

Replying to [ticket:14313 me@…]:

- Use 
+
operator instead of 
typeof === "number"
- Eliminate oldIE specific 
else
condition

Changed January 10, 2014 05:14PM UTC by evan@evoked.us comment:8

I just ran that perf in Chrome 31 and typeof is waaaaay faster (55x to be exact) than the unary version. Is this change definitely worthwhile?

Changed January 10, 2014 05:39PM UTC by dmethvin comment:9

This is an old closed ticket. If you have a proposed change, please put together a pull request, jsperf, and new ticket.