Bug Tracker

Modify

Ticket #14313 (closed bug: fixed)

Opened 8 months ago

Last modified 3 months ago

Optimize jQuery.merge for size

Reported by: me@… Owned by: me@…
Priority: low Milestone: 2.1
Component: core Version: 2.0.3
Keywords: Cc:
Blocking: Blocked by:

Description

  • Use + operator instead of typeof === "number"
  • Eliminate oldIE specific else condition

Change History

comment:1 Changed 8 months ago by timmywil

  • Priority changed from undecided to low
  • Status changed from new to open
  • Component changed from unfiled to core

comment:2 Changed 8 months ago by timmywil

  • Owner set to me@…
  • Status changed from open to assigned

comment:3 Changed 8 months ago by Amey Sakhadeo

  • Status changed from assigned to closed
  • Resolution set to fixed

Fix #14313: Optimize jQuery.merge for size. Close gh-1344.

Changeset: c75c9a8ebb5d2483daa68bec799e0d770083a811

comment:4 Changed 8 months ago by Richard Gibson

Ref #14313: Further code and test improvements

Changeset: f66d53c85643e703a8e37d9ca9375dd386a60cda

comment:5 Changed 7 months ago by Richard Gibson

Ref #14313: NaN detection. Close gh-1352. (cherry picked from commit 0bc0a69026ce4c1ac570a729d3c975a4a55d0ff4)

Changeset: 68213f20bb5d5426f99bafde028ecab601a9d105

comment:6 Changed 7 months ago by dmethvin

  • Milestone changed from None to 2.1

comment:7 in reply to: ↑ description Changed 6 months ago by anonymous

 http://jsperf.com/typeof-number-vs-unary-plus/5

Replying to me@…:

  • Use + operator instead of typeof === "number"
  • Eliminate oldIE specific else condition

comment:8 Changed 3 months ago by evan@…

I just ran that perf in Chrome 31 and typeof is waaaaay faster (55x to be exact) than the unary version. Is this change definitely worthwhile?

comment:9 Changed 3 months ago by dmethvin

This is an old closed ticket. If you have a proposed change, please put together a pull request, jsperf, and new ticket.

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.