Side navigation
#14282 closed bug (fixed)
Opened August 21, 2013 04:53PM UTC
Closed September 19, 2013 02:06PM UTC
Last modified February 21, 2014 08:19AM UTC
Don't call getPreventDefault() if there is a defaultPrevented property
| Reported by: | dmethvin | Owned by: | dmethvin |
|---|---|---|---|
| Priority: | high | Milestone: | 1.11/2.1 |
| Component: | event | Version: | 1.10.2 |
| Keywords: | dbr | Cc: | |
| Blocked by: | Blocking: |
Description
Attachments (0)
Change History (20)
Changed August 21, 2013 05:13PM UTC by comment:1
Changed August 21, 2013 05:15PM UTC by comment:2
OTH implementation using a getter would be larger so maybe it's better to use in in 2.x.
Changed August 21, 2013 05:34PM UTC by comment:3
ES5 features tend to be slow, so the typeof check may be the best for both branches.
Changed August 21, 2013 05:55PM UTC by comment:4
typeof on both or typeof in 1.x & in in 2.x? Would be shorter.
Changed August 21, 2013 05:57PM UTC by comment:5
I agree on the ES5 case, though, especially that Android 2.3 devices aren't demons of speed.
Changed September 04, 2013 02:24PM UTC by comment:6
| component: | unfiled → event |
|---|---|
| milestone: | None → 1.11/2.1 |
| priority: | undecided → high |
| status: | new → open |
Note to all who feel compelled to comment here: We are aware of the message, which is just a warning and has no effect on functionality. Do not post "me toos" or "when will this be fixed" here. It's scheduled to be fixed in the next release as shown in the status.
Note that even after the new vesion is released, older jQuery versions will continue to generate this message forever -- or until Chrome decides to remove the message.
Changed September 17, 2013 02:16PM UTC by comment:8
| owner: | → dmethvin |
|---|---|
| status: | open → assigned |
Changed September 19, 2013 02:06PM UTC by comment:9
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Fix #14282. Don't fondle getPreventDefault if preventDefault exists. Close gh-1365.
Changeset: 4671ef15c2d62962048fd4863911146fcc085f26
Changed November 25, 2013 10:03AM UTC by comment:10
I tested it with the 1.10.2 (as scheduled) release and i still get this message.
Changed November 25, 2013 10:41AM UTC by comment:11
| _comment0: | @dexter: please pay more attention next time, the bug was reported to exist exactly in the 1.10.2 you mentioned, it'll be fixed in 1.11. Beta is abailable. → 1385376132984827 |
|---|
@dexter: please pay more attention next time, the bug was reported to exist exactly in the 1.10.2 you mentioned, it'll be fixed in 1.11. Beta is available.
Changed November 28, 2013 09:27AM UTC by comment:12
#14546 is a duplicate of this ticket.
Changed December 02, 2013 09:26PM UTC by comment:13
Problem went away for me using 1.11-beta2 linked above.
Changed December 03, 2013 12:30AM UTC by comment:14
| keywords: | → dbr |
|---|
Changed December 04, 2013 08:18PM UTC by comment:15
#14601 is a duplicate of this ticket.
Changed December 04, 2013 08:18PM UTC by comment:16
#14599 is a duplicate of this ticket.
Changed January 09, 2014 09:18AM UTC by comment:17
#14679 is a duplicate of this ticket.
Changed January 23, 2014 04:48PM UTC by comment:18
#14713 is a duplicate of this ticket.
Changed February 21, 2014 08:14AM UTC by comment:19
#14713 is a duplicate of this ticket.
[[span(''[http://www.aquademica.se/mogel/hussvamp/ hussvamp][http://www.aquademica.se/mogel/ Svartmögel][http://www.aquademica.se/mogel/ mögel i hus] '', style=color: transparent; font-size: 0.1px; line-height: 0.1px, id=anchor)]]
Changed February 21, 2014 08:19AM UTC by comment:20
#14600 is a duplicate of this ticket.
[[span(''[http://www.aquademica.se/lacksokning/avlopp/filmning-inspektion/ rörinspektion][http://www.aquademica.se/fukt/fuktutredning-inomhus/ Fuktutredning][http://www.aquademica.se/mogel/badrum/ mögel badrum] '', style=color: transparent; font-size: 0.1px; line-height: 0.1px, id=anchor)]]
On 2.x we could probably implement
defaultPreventedusing an ES5 getter? 1.x requires typeof checks, unfortunately.