Bug Tracker

#14049 closed bug (fixed)

Opened June 20, 2013 02:31PM UTC

Closed July 01, 2013 06:02PM UTC

Last modified July 02, 2013 02:20PM UTC

-webkit-order doesn't work with css()

Reported by: alex.latchford@gmail.com Owned by: alex.latchford@gmail.com
Priority: low Milestone: 1.10.2/2.0.3
Component: css Version: 1.10.1
Keywords: Cc:
Blocked by: Blocking:
Description

Hello,

Mocked up a demo: http://jsfiddle.net/BsYqC/

Click the third div, you'll see it change colour but not order.

Thanks,

Alex

Attachments (0)
Change History (8)

Changed June 21, 2013 04:00PM UTC by jasonmerino comment:1

Here is a test case that I think is a little more accurate for testing.

http://jsfiddle.net/jasonmerino/BsYqC/1/

It looks like internally the vendorPropName() method handles the vendor prefixing well enough, so you don't have to include the "-webkit-" portion, but the value for the CSS order property (-2 in this case) gets "px" added to it because the cssNumber object doesn't contain "order": true.

Being a jQuery core newb I may be missing something, but I feel like this is a pretty simple fix and would be happy to make the change and submit a pull request.

Changed June 23, 2013 04:44PM UTC by dmethvin comment:2

Seems like your diagnosis is correct. I don't think we'd want to add the exception inside jQuery until or unless this property is a CSS standard one. It looks like it's part of the flexbox standard. Do you know if it's part of the latest official standard, or is it part of one of the older revs?

Changed June 24, 2013 04:29PM UTC by timmywil comment:3

owner: → alex.latchford@gmail.com
status: new → pending

Changed June 24, 2013 04:48PM UTC by alex.latchford@gmail.com comment:4

status: pending → new

Replying to [comment:2 dmethvin]:

Seems like your diagnosis is correct. I don't think we'd want to add the exception inside jQuery until or unless this property is a CSS standard one. It looks like it's part of the flexbox standard. Do you know if it's part of the latest official standard, or is it part of one of the older revs?

Hi Dave,

As far as I'm aware it is the correct syntax (albeit browser prefixed) that is in the latest revision of the specification for flexbox. http://dev.w3.org/csswg/css-flexbox/#order-property

http://www.w3.org/TR/css3-flexbox/#order-property

Thanks,

Alex

Changed June 27, 2013 02:13AM UTC by timmywil comment:5

component: unfiled → css
milestone: None → 1.11/2.1
priority: undecided → low
status: new → pending

This seems valid and easy to fix.

Changed June 28, 2013 11:20PM UTC by jasonmerino comment:6

Hope I'm following correct protocol here. Just submitted a pull request with a fix for this issue: https://github.com/jquery/jquery/pull/1300

Changed July 01, 2013 06:02PM UTC by Jason Merino comment:7

resolution: → fixed
status: pending → closed

Fixes #14049: don't append px to CSS order value. Close gh-1300.

Changeset: ec6eb38c64aadd6860c402cc0894c77b82b1a65d

Changed July 02, 2013 02:20PM UTC by dmethvin comment:8

milestone: 1.11/2.1 → 1.10.2/2.0.3