#13983 closed bug (fixed)

Opened June 03, 2013 12:47PM UTC

Closed September 05, 2013 04:24PM UTC

Last modified October 15, 2013 02:26PM UTC

Switch to //# for sourcemap directives

Reported by:	dmethvin	Owned by:	m_gol
Priority:	high	Milestone:	1.11/2.1
Component:	build	Version:	1.10.1
Keywords:		Cc:
Blocked by:		Blocking:

Description

The sourcemap r3 proposal has been changed at our request to avoid the issues from #13274. Since nobody recognizes //# at the moment we should give them a few months to update.

Attachments (0)

Change History (15)

Changed June 03, 2013 12:47PM UTC by dmethvin comment:1

component:	unfiled → build
milestone:	None → 1.11/2.1
priority:	undecided → low
status:	new → open

Changed June 13, 2013 07:35AM UTC by Markus.Staab comment:2

Changed June 23, 2013 03:34PM UTC by dmethvin comment:3

#14063 is a duplicate of this ticket.

Changed June 23, 2013 03:36PM UTC by dmethvin comment:4

milestone:	1.11/2.1 → 1.10.2/2.0.3
priority:	low → blocker

Well, thanks Chrome for barfing out a warning. We'll need to change this immediately to prevent a barrage of duplicate tickets.

Changed June 24, 2013 03:01PM UTC by dmethvin comment:5

#14065 is a duplicate of this ticket.

Changed July 02, 2013 01:56PM UTC by Dave Methvin comment:6

resolution:	→ fixed
status:	open → closed

Fix #13983. Switch to //# for sourcemaps.

Normally we'd avoid doing this on a patch release, but Chrome Canary is

spewing deprecation warnings already and that's generating bug tickets.

Changeset: d53ddc90c1f119fb9148a553443ef3fbc3f3cc99

Changed July 02, 2013 09:02PM UTC by Dave Methvin comment:7

Revert "Fix #13983. Switch to # for sourcemaps."

Per the discussion here:

https:code.google.com/p/chromium/issues/detail?id=256636

Thanks to the Chrome team for the quick response!

This reverts commit d53ddc90c1f119fb9148a553443ef3fbc3f3cc99.

Changeset: 6e630fbbb19306e1914712502a2b22872e94ddad

Changed July 02, 2013 09:35PM UTC by dmethvin comment:8

resolution:	fixed
status:	closed → reopened

Changed July 02, 2013 09:36PM UTC by dmethvin comment:9

milestone:	1.10.2/2.0.3 → 1.next
priority:	blocker → high
status:	reopened → open

Changed August 19, 2013 06:03PM UTC by m_gol comment:10

milestone:	1.next → 1.11/2.1

We can do it now, Chromium has implemented the change in v29:

http://omahaproxy.appspot.com/ (v29 has a higher revision number)

and both Firefox & WebKit implemented //@ in the same version as the change to //#.

Changed August 19, 2013 06:06PM UTC by m_gol comment:11

(to be more precise, Firefox has implemented support for both pragmas in v24, Safari will have it starting from 6.1/7.0)

Changed August 19, 2013 06:10PM UTC by m_gol comment:12

owner:	→ m_gol
status:	open → assigned

Changed September 05, 2013 04:24PM UTC by Michał Gołębiowski comment:13

resolution:	→ fixed
status:	assigned → closed

Fix #13983. Switch to //# for sourcemap directives.

Changeset: dfaee326e6605dc6d848c4c5022e39069d2cee65

Changed October 08, 2013 10:20PM UTC by m_gol comment:14

#14433 is a duplicate of this ticket.

Changed October 15, 2013 02:26PM UTC by timmywil comment:15

#14446 is a duplicate of this ticket.

Side navigation