Bug Tracker

Ticket #13755 (closed bug: fixed)

Opened 19 months ago

Last modified 19 months ago

Update .jshintrc to match style guide

Reported by: scott.gonzalez Owned by: timmywil
Priority: low Milestone: 1.10/2.0
Component: build Version: 1.9.1
Keywords: Cc:
Blocking: Blocked by:

Description

See 1. Linting in the  JS style guide.

Change History

comment:1 Changed 19 months ago by timmywil

  • Owner set to timmywil
  • Priority changed from undecided to low
  • Status changed from new to assigned
  • Component changed from unfiled to build
  • Milestone changed from None to 1.10/2.0

comment:2 Changed 19 months ago by Timmy Willison

  • Status changed from assigned to closed
  • Resolution set to fixed

Update jshintrc to conform to new style guide. Conform to onevar and unused in tests. Fixes #13755.

Changeset: 0fa52c11cbfe70780648b99717f1dd3502befaff

comment:3 Changed 19 months ago by timmywil

We can't do onevar in core src because we lint the concatenated file and we shouldn't place variables specific to certain modules somewhere besides the module itself. However, onevar now works in the gruntfile and in the tests.

comment:4 Changed 19 months ago by timmywil

Added onevar to jshintrc, but removed it for the concatenated file:

 https://github.com/jquery/jquery/commit/738b8f84310f3d33d22fae976b83d94a684e01a8

Note: See TracTickets for help on using tickets.