Bug Tracker

Modify

Ticket #13577 (closed bug: fixed)

Opened 14 months ago

Last modified 12 months ago

New minimal selector engine fails on textNode objects

Reported by: albertcasademont@… Owned by: timmywil
Priority: low Milestone: 2.0.1
Component: selector Version: 2.0b2
Keywords: Cc:
Blocking: Blocked by:

Description

textNode objects don't have the querySelectorAll function available. Maybe we could prevent querying on those types of nodes an avoid a js error?

 http://jsfiddle.net/ueGbS/1/

Change History

comment:1 Changed 13 months ago by timmywil

  • Owner set to timmywil
  • Priority changed from undecided to low
  • Status changed from new to assigned
  • Component changed from unfiled to selector

We'll just fail silently for text nodes.

comment:2 Changed 13 months ago by dmethvin

  • Milestone changed from None to 2.0

comment:3 Changed 12 months ago by dmethvin

  • Milestone changed from 2.0 to 2.0.1

comment:4 Changed 12 months ago by Timmy Willison

  • Status changed from assigned to closed
  • Resolution set to fixed

Check nodeType of elements passed to selector-native's find. Fixes #13577.

Changeset: 8d3c0506c860e887d0005fd12da53f1d11ce2883

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.