Ticket #13316 (closed bug: fixed)
Check against jquery.min.js with TestSwarm
| Reported by: | gibson042 | Owned by: | dmethvin |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.9.1 |
| Component: | build | Version: | git |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
Ref #13315.
Checking against minified source is probably more important than unminified, yet we currently don't do the former.
Change History
comment:1 Changed 4 months ago by dmethvin
- Owner set to dmethvin
- Priority changed from undecided to blocker
- Status changed from new to assigned
- Component changed from unfiled to build
- Milestone changed from None to 1.9.1
comment:2 Changed 4 months ago by jaubourg
If we have to debug problems in IE6/7/8, let's keep an option to test with the non-minified version though ;P
comment:3 Changed 4 months ago by dmethvin
I just made the change in all the files on both 1.9 and 2.0, we had a checkbox for the minified version so I just switched that to the unminified.
However, all the iframed tests don't heed that setting, so if you had to debug one of those you'd need to edit the unit test.
The 1.9 build seems to be borked due to grunt issues so I need to fix that before pushing these up.
comment:4 Changed 4 months ago by Dave Methvin
- Status changed from assigned to closed
- Resolution set to fixed
Fix #13316. Use minified version in unit testing.
Changeset: 58cd84f9d55ba8ce4311265990bd94cea73c4725
comment:5 Changed 4 months ago by Dave Methvin
Fix #13316. Use minified version in unit testing.
Also migrates the XHR check added to 2.0 in 62acda819f9b6fba9263d0b613e15285807b23a7.
Changeset: a3055f3df63661ad1221db44d04ec92ece130a8c
comment:6 Changed 4 months ago by Richard Gibson
Ref #13316: Sync all documents on full vs. minified source. Close gh-1147.
Changeset: 363299ac24aebbf2445207621840f44fcaaf670a
comment:7 Changed 4 months ago by Richard Gibson
Ref #13316: Sync all test documents on full vs. minified source.
Changeset: 67a2e4eaac98cee79a02a0a45e4826a7958d4b75
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.
This is to some extent a hangover from our previous use of unbuilt files during testing, but we might as well just use the minified version in unit tests now that we require a build.