Side navigation
#13316 closed bug (fixed)
Opened January 24, 2013 05:19AM UTC
Closed January 26, 2013 06:38PM UTC
Last modified February 08, 2013 05:22AM UTC
Check against jquery.min.js with TestSwarm
| Reported by: | gibson042 | Owned by: | dmethvin |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.9.1 |
| Component: | build | Version: | git |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Ref #13315.
Checking against minified source is probably more important than unminified, yet we currently don't do the former.
Attachments (0)
Change History (7)
Changed January 26, 2013 03:01PM UTC by comment:1
| component: | unfiled → build |
|---|---|
| milestone: | None → 1.9.1 |
| owner: | → dmethvin |
| priority: | undecided → blocker |
| status: | new → assigned |
Changed January 26, 2013 04:05PM UTC by comment:2
If we have to debug problems in IE6/7/8, let's keep an option to test with the non-minified version though ;P
Changed January 26, 2013 04:12PM UTC by comment:3
I just made the change in all the files on both 1.9 and 2.0, we had a checkbox for the minified version so I just switched that to the unminified.
However, all the iframed tests don't heed that setting, so if you had to debug one of those you'd need to edit the unit test.
The 1.9 build seems to be borked due to grunt issues so I need to fix that before pushing these up.
Changed January 26, 2013 06:38PM UTC by comment:4
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Fix #13316. Use minified version in unit testing.
Changeset: 58cd84f9d55ba8ce4311265990bd94cea73c4725
Changed January 26, 2013 06:39PM UTC by comment:5
Fix #13316. Use minified version in unit testing.
Also migrates the XHR check added to 2.0 in 62acda819f9b6fba9263d0b613e15285807b23a7.
Changeset: a3055f3df63661ad1221db44d04ec92ece130a8c
This is to some extent a hangover from our previous use of unbuilt files during testing, but we might as well just use the minified version in unit tests now that we require a build.