Skip to main content

Bug Tracker

Side navigation

#13160 closed bug (fixed)

Opened January 06, 2013 08:53AM UTC

Closed January 08, 2013 03:39PM UTC

Last modified January 08, 2013 06:18PM UTC

Deferred.then doesn't propagete custom context

Reported by: nanto_vi Owned by: jaubourg
Priority: blocker Milestone: 1.9
Component: deferred Version: 1.9b1
Keywords: Cc:
Blocked by: Blocking:
Description

jQuery 1.9b1 changed a context (value of 'this') in piped promises.

This change affects codes that expect context to be propagated such as:

function ajaxWithRescueFrom404(settings) {
  return $.ajax(settings).then(null, function (xhr, status) {
    return (xhr.status === 404)
      ? $.Deferred().resolveWith(this, ['', status, xhr])
      : this;
  });
}

ajaxWithResuceFrom404({ url: ... }).done(function () {
  // Treat 404 response as same as succeeded response.
  // Expect that 'this' is a settings object.
});

The commit https://github.com/nanto/jquery/commit/cdac527be80fb2c6585ce6f53a83d4a9144fbf4d fixes this problem.

Attachments (0)
Change History (5)

Changed January 06, 2013 12:56PM UTC by jaubourg comment:1

component: unfileddeferred
milestone: None1.9
owner: → jaubourg
priority: undecidedblocker
status: newassigned

Can you make this a full-fledged pull request with unit tests to boot?

Changed January 06, 2013 06:18PM UTC by nanto_vi comment:2

Changed January 08, 2013 03:39PM UTC by nanto_vi comment:3

resolution: → fixed
status: assignedclosed

Propagete context of returned deferred object in Deferred.then(). Fixes #13160

Changeset: e7fdda981928befda72b78e9e2b17e33e232a603

Changed January 08, 2013 03:40PM UTC by nanto comment:4

Propagate context of returned deferred object in Deferred.then(). Fixes #13160.

Changeset: 2f6b3f818fc51ee6ae44be69dc6b15b3d7a2dad4

Changed January 08, 2013 06:18PM UTC by nanto comment:5

Propagate context of returned deferred object in Deferred.then(). Fixes #13160.

Changeset: 0c5d2fbabb39ef53a798535bc58690d34ea21351