Side navigation
#13089 closed bug (fixed)
Opened December 19, 2012 09:25AM UTC
Closed February 03, 2013 06:56PM UTC
Last modified February 03, 2013 07:12PM UTC
support adds zoom style to body in Chrome/Safari
| Reported by: | Zak Johnson <zakj@nox.cx> | Owned by: | Zak Johnson <zakj@nox.cx> |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.9.1 |
| Component: | support | Version: | 1.9b1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
On any browser for which typeof div.style.zoom isn't undefined, body.style.zoom is set to 1. Unfortunately, (at least) Chrome 24 and Safari 6 seem to support that property. Test case:
This is a regression from 1.8.3, introduced in https://github.com/jquery/jquery/pull/1025.
Attachments (0)
Change History (13)
Changed December 21, 2012 04:09AM UTC by comment:1
| owner: | → Zak Johnson <zakj@nox.cx> |
|---|---|
| status: | new → pending |
Changed December 21, 2012 04:55AM UTC by comment:2
| status: | pending → new |
|---|
Confusion about who set the style and why. Aside from that, I don't know.
Changed December 28, 2012 04:54PM UTC by comment:3
| component: | unfiled → support |
|---|---|
| milestone: | None → 1.9 |
| priority: | undecided → low |
| status: | new → open |
It's unnecessary to set in Chrome and Safari at least.
Changed December 28, 2012 05:11PM UTC by comment:4
Actually, Opera does support zoom, too (IMHO Firefox is the only significant browser that doesn't) but the style doesn't get applied there; what could be the reason?
Changed January 25, 2013 08:44PM UTC by comment:6
This breaks the CSS grid in Chrome. Thanks for throwing a huge wrench in my already filled day.
Changed January 26, 2013 02:55PM UTC by comment:8
| milestone: | 1.9 → 1.9.1 |
|---|---|
| priority: | low → blocker |
Changed January 29, 2013 04:03PM UTC by comment:10
Just including 'jquery-1.9.0.min.js' causes JS errors on Opera 12.12: 'Invalid value for property: zoom'
Changed February 01, 2013 02:55AM UTC by comment:11
The commit, for reference:
https://github.com/jquery/jquery/commit/84629a9b876f6969777b43f3229b62b43bb624d2
We need to condition that by something that only applies in oldIE-land. There are a couple of support properties in the vicinity.
Changed February 03, 2013 06:56PM UTC by comment:12
| resolution: | → fixed |
|---|---|
| status: | open → closed |
Fix #13089. Only apply zoom to IE6/7 body.
Changeset: 219a1935eea509bf147a05ef9d47502d8230991d
Changed February 03, 2013 07:12PM UTC by comment:13
zoom of doom goes kaboom?
Does this cause any problem?