Bug Tracker

Ticket #12957 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

Improve wrapMap

Reported by: markel Owned by: markel
Priority: low Milestone: 1.9
Component: manipulation Version: 1.8.3
Keywords: Cc:
Blocking: Blocked by:

Description

In most cases end tags are unnecessary and their absence make jQuery.buildFragment even more consistent across browsers, when jQuery.clean takes incorrect HTML argument as a string.

 https://github.com/jquery/jquery/pull/1044

Change History

comment:1 Changed 2 years ago by rwaldron

In the PR provided, I don't see any proof of "more consistent across browsers". Some tests would be ideal, as what I _am_ seeing is the removal of a test, but no additions.

comment:2 Changed 2 years ago by markel

@rwaldron If i add tests it would mean that jQuery can take "incorrect HTML argument as a string", which is not true.

comment:3 Changed 2 years ago by timmywil

  • Status changed from new to assigned
  • Component changed from unfiled to manipulation
  • Priority changed from undecided to low
  • Version changed from git to 1.8.3
  • Milestone changed from None to 1.9
  • Owner set to markel

comment:4 Changed 2 years ago by Oleg

  • Status changed from assigned to closed
  • Resolution set to fixed

Fix #12957. Simplify wrapMap, it doesn't need end tags. Close gh-1044.

Changeset: 9ae6b1a019553e95a6205d5c42ff7fa25e7a482e

Note: See TracTickets for help on using tickets.