Side navigation
#12846 closed bug (fixed)
Opened November 05, 2012 12:04AM UTC
Closed January 27, 2013 03:03AM UTC
Last modified January 27, 2013 07:09PM UTC
overflow:hidden is not removed when .stop() is called
Reported by: | Ult Combo | Owned by: | mikesherov |
---|---|---|---|
Priority: | low | Milestone: | 1.9.1 |
Component: | effects | Version: | 1.8.2 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
I'm aware that when animating the dimensions of a div
, overflow:hidden
is added to the element style in order to don't show scrollbars.
The overflow
property is removed from the element style when the animation is complete. However, that doesn't happen when I call the .stop
method.
Normal behavior - Without .stop()
, scrollbars are hidden while animating and restored to default after animation.
Test case - trigger the div
's mouseenter
then mouseleave
while it is animating to invoke the .stop()
method, the overflow:hidden
stays in the element style and scrollbars are gone for good.
Temporary workaround: Set overflow:auto !important;
in the CSS when the div
is supposed to have scrollbars.
Proposed patch: remove the added overflow:hidden
from the element style when .stop()
is invoked.
I'd suggest not adding the overflow
property if the element already has one, but in that case it could break back-compat. Therefore simply restoring the overflow
when .stop()
is called as if the animation had completed should suffice.
Attachments (0)
Change History (6)
Changed November 05, 2012 03:25PM UTC by comment:1
component: | unfiled → effects |
---|---|
milestone: | None → 1.next |
priority: | undecided → low |
status: | new → open |
Changed December 29, 2012 04:49AM UTC by comment:3
owner: | → mikesherov |
---|---|
status: | open → assigned |
this one is as simple as changing
anim.doneto
anim.alwaysfor the overflow sets. Will have a pull request shortly.
Changed January 27, 2013 03:03AM UTC by comment:4
resolution: | → fixed |
---|---|
status: | assigned → closed |
Fix #12846. Restore overflow when animation is stopped.
Changeset: a6c358d04693c5746e1557a2660dfccb169ad831
Changed January 27, 2013 03:08AM UTC by comment:5
Fix #12846. Restore overflow when animation is stopped.
(Cherry picked from a6c358d)
Changeset: 3f9f2b1dbcefdafc5ef11f7deb222a3b6d8941d8
Changed January 27, 2013 07:09PM UTC by comment:6
milestone: | 1.next → 1.9.1 |
---|
This sounds really familiar, but I can't find a related ticket.