Bug Tracker

Modify ↓

Ticket #12665 (closed bug: fixed)

Opened 8 months ago

Last modified 8 months ago

Callbacks objects with "unique" flag will iterate over a function's methods when it is added a second time

Reported by: jaubourg Owned by: jaubourg
Priority: blocker Milestone: 1.8.3
Component: deferred Version: git
Keywords: Cc:
Blocking: Blocked by:

Description

 Fiddle

Culprit is  too wide a test that will make Callbacks.add iterate over a function that is defined with at least a single parameter and has already been added to the same Callbacks instance.

Reported on github by  kselden  here.

Change History

comment:1 Changed 8 months ago by jaubourg

  • Owner set to jaubourg
  • Priority changed from undecided to blocker
  • Status changed from new to assigned
  • Component changed from unfiled to deferred
  • Milestone changed from None to 1.8.3

comment:2 Changed 8 months ago by jaubourg

  • Status changed from assigned to closed
  • Resolution set to fixed

Do not iterate over functions. Fixes #12665. Unit tests added. Thanks to @kselden for finding the bug.

Changeset: bb38f706463a4d7598505b2f7adf3ed83935f298

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View ↑

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.