Side navigation
#12411 closed feature (fixed)
Opened August 28, 2012 01:55PM UTC
Closed September 23, 2012 08:59AM UTC
Last modified October 22, 2012 01:09AM UTC
.removeClass(undefined) works not as expected
| Reported by: | matthias.jaeggli@gmail.com | Owned by: | matthias.jaeggli@gmail.com |
|---|---|---|---|
| Priority: | low | Milestone: | None |
| Component: | attributes | Version: | 1.8.0 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
An empty function call is not the same, as calling a function with an undefined variable.
If we check against !arguments.length instead of undefined, we can tell apart these situations.
OLD:
.removeClass() - removes all classes, as expected
.removeClass(undefined) - also removes all classes, which is wrong in my eyes
Fix:
.removeClass(undefined) - removes nothing, like null, false and "" do
Pull Request https://github.com/jquery/jquery/pull/913
PS:
I noticed this while calling element.removeClass(someObject.someVar);
where the object was defined, but someVar was undefined, so this is a pretty common situation, I think.
Attachments (0)
Change History (5)
Changed August 28, 2012 02:22PM UTC by comment:1
| component: | unfiled → attributes |
|---|---|
| owner: | → matthias.jaeggli@gmail.com |
| priority: | undecided → low |
| status: | new → pending |
| type: | bug → enhancement |
Changed August 28, 2012 09:59PM UTC by comment:2
jsFiddle: http://jsfiddle.net/jaggli/npkgS/
Changed September 09, 2012 04:21AM UTC by comment:3
| type: | enhancement → feature |
|---|
Changed September 23, 2012 08:59AM UTC by comment:4
| resolution: | → invalid |
|---|---|
| status: | pending → closed |
Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!
Changed October 22, 2012 01:09AM UTC by comment:5
| resolution: | invalid → fixed |
|---|
Fix #12411, .removeClass(undefined) is a chaining no-op. Close gh-913.
.removeClass() removes all classes, as documented
.removeClass(window.nonExistentVariable) removes nothing
Changeset: 227c49a4596423a125bdcb1d25a2263e526360db
Please add a test supporting this change in the PR.