Bug Tracker

Ticket #12148 (closed bug: fixed)

Opened 2 years ago

Last modified 2 years ago

hide event don't fire when toggle

Reported by: anonymous Owned by:
Priority: blocker Milestone: 1.8
Component: css Version: 1.8b2
Keywords: Cc:
Blocking: Blocked by:

Description

see  http://jsfiddle.net/hQ6P2/1/ created hide event doesn't fire when toggle in jquery edge while it worked well for previous versions

Change History

comment:1 Changed 2 years ago by dmethvin

  • Priority changed from undecided to blocker
  • Status changed from new to open
  • Component changed from unfiled to css
  • Milestone changed from None to 1.8

Yes, $.fn.toggle() doesn't call $.fn.hide() or $.fn.show() right now in 1.8, so it can't be duck punched.

comment:2 Changed 2 years ago by Dave Methvin

  • Status changed from open to closed
  • Resolution set to fixed

Fix #12148. Let .toggle() call the public .hide() for punching.

There is a slightly shorter way to do this but it's not Closure-friendly.

Changeset: ed898c62c8d3e8c2091592976c181ee4142287ac

Note: See TracTickets for help on using tickets.