Bug Tracker

#12148 closed bug (fixed)

Opened July 25, 2012 07:23PM UTC

Closed July 26, 2012 01:27AM UTC

hide event don't fire when toggle

Reported by: anonymous Owned by:
Priority: blocker Milestone: 1.8
Component: css Version: 1.8b2
Keywords: Cc:
Blocked by: Blocking:
Description

see http://jsfiddle.net/hQ6P2/1/

created hide event doesn't fire when toggle in jquery edge while it worked well for previous versions

Attachments (0)
Change History (2)

Changed July 25, 2012 07:54PM UTC by dmethvin comment:1

component: unfiled → css
milestone: None → 1.8
priority: undecided → blocker
status: new → open

Yes, $.fn.toggle() doesn't call $.fn.hide() or $.fn.show() right now in 1.8, so it can't be duck punched.

Changed July 26, 2012 01:27AM UTC by Dave Methvin comment:2

resolution: → fixed
status: open → closed

Fix #12148. Let .toggle() call the public .hide() for punching.

There is a slightly shorter way to do this but it's not Closure-friendly.

Changeset: ed898c62c8d3e8c2091592976c181ee4142287ac