Bug Tracker

Modify

Ticket #12059 (closed enhancement: fixed)

Opened 22 months ago

Last modified 21 months ago

`grunt custom` should minify - also should add excluded modules to headers

Reported by: mathias Owned by: gnarf
Priority: undecided Milestone: 1.8
Component: build Version: git
Keywords: Cc: rwaldron
Blocking: Blocked by:

Description

It would be useful if e.g. grunt custom:-deprecated would also create a dist/jquery.min.js.

IMHO having to run grunt min after creating a custom build is confusing. Imagine the following scenario:

  • A dev checks out the jQuery repo, runs grunt to create a full build, and runs some tests.
  • Later the dev decides to create a custom build, and runs grunt custom:-ajax.
  • Now there is a dist/jquery.min.js, but it’s not the minified version of the custom build.

I suppose this could be solved quite easily by making grunt custom or (even better) grunt build run grunt min afterwards.

Change History

comment:1 Changed 22 months ago by dmethvin

  • Status changed from new to open

We need to change the comment header for both files to indicate that it is a custom build and which modules were excluded.

comment:2 Changed 22 months ago by mathias

  • Cc rwaldron added

comment:3 Changed 22 months ago by mathias

  • Milestone changed from None to 1.8

comment:4 Changed 22 months ago by gnarf

  • Owner set to gnarf
  • Status changed from open to assigned

comment:5 Changed 22 months ago by gnarf

  • Summary changed from `grunt custom` should save a minified version of the custom build in dist/jquery.min.js to `grunt custom` should minify - also should add excluded modules to headers

comment:6 Changed 22 months ago by Corey Frang

  • Status changed from assigned to closed
  • Resolution set to fixed

grunt custom saves minified version automattically. Close gh-856, Fixes #12059

Changeset: faf2eb4a8f9ff26f43773128ed2be8283314b3b6

comment:7 Changed 21 months ago by dmethvin

  • Component changed from unfiled to build

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.