Side navigation
#12059 closed enhancement (fixed)
Opened July 11, 2012 12:16PM UTC
Closed July 11, 2012 01:54PM UTC
Last modified August 10, 2012 12:09AM UTC
`grunt custom` should minify - also should add excluded modules to headers
Reported by: | mathias | Owned by: | gnarf |
---|---|---|---|
Priority: | undecided | Milestone: | 1.8 |
Component: | build | Version: | git |
Keywords: | Cc: | rwaldron | |
Blocked by: | Blocking: |
Description
It would be useful if e.g. grunt custom:-deprecated
would also create a dist/jquery.min.js
.
IMHO having to run grunt min
after creating a custom build is confusing. Imagine the following scenario:
- A dev checks out the jQuery repo, runs
grunt
to create a full build, and runs some tests. - Later the dev decides to create a custom build, and runs
grunt custom:-ajax
. - Now there is a
dist/jquery.min.js
, but it’s not the minified version of the custom build.
I suppose this could be solved quite easily by making grunt custom
or (even better) grunt build
run grunt min
afterwards.
Attachments (0)
Change History (7)
Changed July 11, 2012 12:21PM UTC by comment:1
status: | new → open |
---|
Changed July 11, 2012 12:21PM UTC by comment:2
cc: | → rwaldron |
---|
Changed July 11, 2012 12:23PM UTC by comment:3
milestone: | None → 1.8 |
---|
Changed July 11, 2012 12:48PM UTC by comment:4
owner: | → gnarf |
---|---|
status: | open → assigned |
Changed July 11, 2012 12:49PM UTC by comment:5
summary: | `grunt custom` should save a minified version of the custom build in dist/jquery.min.js → `grunt custom` should minify - also should add excluded modules to headers |
---|
Changed July 11, 2012 01:54PM UTC by comment:6
resolution: | → fixed |
---|---|
status: | assigned → closed |
grunt custom saves minified version automattically. Close gh-856, Fixes #12059
Changeset: faf2eb4a8f9ff26f43773128ed2be8283314b3b6
Changed August 10, 2012 12:09AM UTC by comment:7
component: | unfiled → build |
---|
We need to change the comment header for both files to indicate that it is a custom build and which modules were excluded.