Skip to main content

Bug Tracker

Side navigation

#11969 closed bug (fixed)

Opened June 25, 2012 02:30PM UTC

Closed June 26, 2012 09:09PM UTC

Last modified July 10, 2012 09:35PM UTC

Missing null check when gathering siblings

Reported by: dmethvin Owned by: dmethvin
Priority: blocker Milestone: 1.8
Component: selector Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:
Description

Ref http://bugs.jqueryui.com/ticket/8409

Not sure why the null check for cur was removed.

Attachments (0)
Change History (8)

Changed June 25, 2012 02:31PM UTC by dmethvin comment:1

component: unfiledselector
milestone: None1.8
priority: undecidedblocker
status: newopen

Reported by FJ1 in IRC.

Changed June 25, 2012 03:48PM UTC by timmywil comment:2

Looks like this reduction commit removed the null check by accident: https://github.com/jquery/jquery/commit/df254d47e43e6e1652b20a3b338b26f634cd2b2a#src/traversing.js

Changed June 25, 2012 04:07PM UTC by dmethvin comment:3

owner: → dmethvin
status: openassigned

Changed June 26, 2012 03:27AM UTC by dmethvin comment:4

#11968 is a duplicate of this ticket.

Changed June 26, 2012 09:09PM UTC by Dave Methvin comment:5

resolution: → fixed
status: assignedclosed

Fix #11969. Never a null moment when checking siblings.

Changeset: cde4c326b82af4679026a202f02799e9fbd18cb4

Changed June 27, 2012 04:57AM UTC by FlashJunior comment:6

thank you so much! all my tests are working now!

Changed July 05, 2012 01:00PM UTC by dmethvin comment:7

#12019 is a duplicate of this ticket.

Changed July 10, 2012 09:35PM UTC by dmethvin comment:8

#12053 is a duplicate of this ticket.