Bug Tracker

#11925 closed bug (fixed)

Opened June 18, 2012 02:40AM UTC

Closed June 22, 2012 08:38PM UTC

special.teardown should pass the handle as second argument

Reported by: Krinkle Owned by:
Priority: undecided Milestone: None
Component: unfiled Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:
Description

The code in jQuery.event.special.beforeunload.teardown assumes this second argument, but it is not being passed.

This causes the eventHandle to stay long after the last event has been unbound. (e.g. off('beforeunload', fn) does not remove handle from the property).

Attachments (0)
Change History (2)

Changed June 18, 2012 02:49AM UTC by Krinkle comment:1

https://github.com/jquery/jquery/pull/831

Changed June 22, 2012 08:38PM UTC by Timo Tijhof comment:2

resolution: → fixed
status: new → closed

Fix #11925, Pass eventHandle to special.teardown. Closes gh-831.

  • Added unit test to confirm.

The third assertion fails without the fix in ./src/event.js

Changeset: 9bb3494ce99889e05a7333e38e4da9579ce6af8e