Bug Tracker

Modify

Ticket #11435 (closed bug: fixed)

Opened 2 years ago

Last modified 21 months ago

Obsolete test code to remove toJSON from .data's return value

Reported by: amonat@… Owned by:
Priority: low Milestone: 1.8
Component: data Version: git
Keywords: Cc:
Blocking: Blocked by:

Description

The ".data()" test in test/unit/data.js has this code (in 2 places):

	// TODO: Remove this hack which was introduced for 1.5.1
	delete dataObj.toJSON;

Commit d5f144a7 changed the way jQuery.data() works so that the .toJSON isn't included, so I think this code is no longer necessary. I removed it and the test still passed.

Change History

comment:1 Changed 2 years ago by addyosmani

  • Priority changed from undecided to low
  • Status changed from new to open

This was just mentioned in -meeting and it looks like we're going to try addressing it. Marking as valid.

comment:2 Changed 2 years ago by Andy Monat

  • Status changed from open to closed
  • Resolution set to fixed

Fix #11435. Remove obsolete test code.

Changeset: dc337f628c0d2a4f6d691851eb95a622599e38b2

comment:3 Changed 2 years ago by dmethvin

  • Milestone changed from None to 1.8

comment:4 Changed 21 months ago by dmethvin

  • Component changed from unfiled to data

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.