Side navigation
#10931 closed enhancement (fixed)
Opened December 01, 2011 06:30AM UTC
Closed January 13, 2012 01:05AM UTC
Last modified March 08, 2012 02:08PM UTC
Unit tests shouldn't require internet access
| Reported by: | gibson042 | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | 1.7.2 |
| Component: | build | Version: | 1.7.1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
I was working on jQuery while waiting for internet service to be restored today, and discovered an unexpected failure in the selector unit test module.
The "sizzle_cache" test loads data/selector/sizzle_cache.html, which requests http://code.jquery.com/jquery-git.js so it can store jQuery.noConflict(true) and then replace it from local files. But since the only purpose of this test is to check behavior with parallel copies of Sizzle, local sources should be sufficient for both jQuerys.
The test will pass without internet access if the request for jquery-git.js is replaced with local core.js + selector.js + traversing.js.
Attachments (0)
Change History (6)
Changed December 01, 2011 10:46AM UTC by comment:1
| priority: | undecided → low |
|---|---|
| status: | new → open |
Changed December 07, 2011 06:26AM UTC by comment:2
Changed January 12, 2012 07:18PM UTC by comment:3
New hotness: https://github.com/jquery/jquery/pull/655
Changed January 13, 2012 01:05AM UTC by comment:4
| resolution: | → fixed |
|---|---|
| status: | open → closed |
Fix #10931: Make unit tests work without web access.
Applies https://github.com/gibson042/jquery/tree/10931 to
dd900460ac6f77be71ceb878bc2cd1465397dc60
Changeset: 6c8dd7e7d3a00133591d4f9c05c207900234e11e
Changed January 13, 2012 01:38AM UTC by comment:5
| component: | unfiled → build |
|---|---|
| milestone: | None → 1.7.2 |
Changed March 08, 2012 02:08PM UTC by comment:6
#!html
<ul class="changes"><li>
<strong>Changed</strong> from Review to <i>Test Case </i><a style='color:white' href='http://obtenir-rio.info/'>rio orange</a>
<a style='color:white' href='http://portabilite.info'>portabilite du numero</a>
<a style='color:white' href='http://calcul-imc.info'>imc</a></li><li>
<strong>Status</strong> changed from <em>reopened</em> to <em>closed</em>
<a style='color:white' href='http://le-meilleur-forfait.com/'>comparateur forfait mobile</a>
<a style='color:white' href='http://le-meilleur-forfait.com/sans_engagement'>forfait sans engagement</a>
<a style='color:white' href='http://le-meilleur-forfait.com/illimite'>forfait illimite</a>
<a style='color:white' href='http://le-meilleur-forfait.com/sms_illimite'>sms illimite</a>
<a style='color:white' href='http://le-meilleur-forfait.com/internet'>forfait internet mobile</a>
<a style='color:white' href='http://le-meilleur-forfait.com/bloque'>forfait bloque</a>
<a style='color:white' href='http://le-meilleur-forfait.com/blackberry'>forfait blackberry</a></li></ul>