Ticket #10931 (closed enhancement: fixed)
Unit tests shouldn't require internet access
| Reported by: | gibson042 | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | 1.7.2 |
| Component: | build | Version: | 1.7.1 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
I was working on jQuery while waiting for internet service to be restored today, and discovered an unexpected failure in the selector unit test module.
The "sizzle_cache" test loads data/selector/sizzle_cache.html, which requests http://code.jquery.com/jquery-git.js so it can store jQuery.noConflict(true) and then replace it from local files. But since the only purpose of this test is to check behavior with parallel copies of Sizzle, local sources should be sufficient for both jQuerys.
The test will pass without internet access if the request for jquery-git.js is replaced with local core.js + selector.js + traversing.js.
Change History
comment:1 Changed 18 months ago by sindresorhus
- Priority changed from undecided to low
- Status changed from new to open
comment:3 Changed 17 months ago by gibson042
New hotness: https://github.com/jquery/jquery/pull/655
comment:4 Changed 17 months ago by Richard Gibson
- Status changed from open to closed
- Resolution set to fixed
Fix #10931: Make unit tests work without web access.
Applies https://github.com/gibson042/jquery/tree/10931 to
Changeset: 6c8dd7e7d3a00133591d4f9c05c207900234e11e
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.