Bug Tracker

Modify

Ticket #10931 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

Unit tests shouldn't require internet access

Reported by: gibson042 Owned by:
Priority: low Milestone: 1.7.2
Component: build Version: 1.7.1
Keywords: Cc:
Blocking: Blocked by:

Description

I was working on jQuery while waiting for internet service to be restored today, and discovered an unexpected failure in the selector unit test module.

The "sizzle_cache" test loads data/selector/sizzle_cache.html, which requests  http://code.jquery.com/jquery-git.js so it can store jQuery.noConflict(true) and then replace it from local files. But since the only purpose of this test is to check behavior with parallel copies of Sizzle, local sources should be sufficient for both jQuerys.

The test will pass without internet access if the request for jquery-git.js is replaced with local core.js + selector.js + traversing.js.

Change History

comment:1 Changed 2 years ago by sindresorhus

  • Priority changed from undecided to low
  • Status changed from new to open

comment:3 Changed 2 years ago by gibson042

comment:4 Changed 2 years ago by Richard Gibson

  • Status changed from open to closed
  • Resolution set to fixed

comment:5 Changed 2 years ago by dmethvin

  • Component changed from unfiled to build
  • Milestone changed from None to 1.7.2

comment:6 Changed 2 years ago by anonymous

Please follow the  bug reporting guidlines and use  jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.

View

Add a comment

Modify Ticket

Action
as closed
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.