Ticket #10877 (closed feature: fixed)
Make outerWidth/Height a setter
| Reported by: | jzaefferer | Owned by: | mikesherov |
|---|---|---|---|
| Priority: | low | Milestone: | 1.8 |
| Component: | dimensions | Version: | 1.7.1 |
| Keywords: | Cc: | scott.gonzalez | |
| Blocking: | Blocked by: |
Description (last modified by rwaldron) (diff)
The math required by the regular boxmodel leaves it traces in a lot of places where we need to set the width or height of an element that has border, padding or margin.
jQuery UI currently extends inner/outer/Width/Height as setters, but we only use the outerXxx methods: https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.core.js#L132-L174
By actually integrating that in core, the require code would obviously be a lot less. For consistency it might make sense to make both outerXxx and innerXxx a setter, but really only outer is important.
Change History
comment:2 Changed 19 months ago by timmywil
- Keywords 1.8-discuss added
- Status changed from new to open
- Version changed from git to 1.7.1
- Component changed from unfiled to dimensions
- Type changed from enhancement to feature
comment:6 Changed 18 months ago by dmethvin
- Description modified (diff)
+1, Yes, but as with everything in 1.8 contingent on final size. This intersects with our box-sizing: border-box issues as well.
comment:7 Changed 18 months ago by mikesherov
- Description modified (diff)
+1, This is something people would expect jQuery to handle, and I'd love to work on this, so yes. Also, we can pretty much just rip the code straight from jquery ui. I do have some concerns though with code paths for hidden elements, but should be fun to implement.
comment:10 Changed 15 months ago by mikesherov
- Owner set to mikesherov
- Status changed from open to assigned
comment:11 Changed 15 months ago by mikesherov
- Keywords 1.8-discuss removed
- Priority changed from undecided to low
- Milestone changed from None to 1.8
comment:12 Changed 14 months ago by ALLPRO
+1 -- have wondered why this was not done a long time ago
comment:13 Changed 13 months ago by mikesherov
comment:14 Changed 13 months ago by timmywil
I'm still a -1 on this feauture, especially given the added size to core.
comment:15 Changed 13 months ago by mikesherov
@timmywil, I hear the concern. There are strategies for smaller size that I outlined in the PR. Thoughts?
comment:16 Changed 13 months ago by Mike Sherov
- Status changed from assigned to closed
- Resolution set to fixed
Fix #10877. Make outerWidth/Height a setter. Closes gh-783.
Changeset: e0151e5827d7091f311c82d9f951aaaa2688ba8c
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.