Skip to main content

Bug Tracker

Side navigation

#10819 closed enhancement (fixed)

Opened November 17, 2011 06:32PM UTC

Closed December 06, 2011 10:21PM UTC

Last modified December 10, 2011 06:41PM UTC

Eliminate "this.on.call(this, "

Reported by: anonymous Owned by: rwaldron
Priority: low Milestone: 1.7.2
Component: event Version: git
Keywords: Cc:
Blocked by: Blocking:
Description
one: function( types, selector, data, fn ) {
    return this.on.call( this, types, selector, data, fn, 1 );
},

can be simplified to:

one: function( types, selector, data, fn ) {
    return this.on( types, selector, data, fn, 1 );
},

since the this value is determined implicitly. Eliminating the extraneous .call(this, saves 10 bytes from the minified file.

Attachments (0)
Change History (3)

Changed November 17, 2011 07:19PM UTC by rwaldron comment:1

component: unfiledevent
milestone: None1.next
owner: → rwaldron
priority: undecidedlow
status: newassigned

Changed December 06, 2011 10:21PM UTC by Rick Waldron comment:2

resolution: → fixed
status: assignedclosed

Remove unnec .call( this... from one: function() {}. Fixes #10819

Changeset: 64df670a81e70fdece1049129523bb2ad1bc2858

Changed December 10, 2011 06:41PM UTC by dmethvin comment:3

milestone: 1.next1.7.2