Side navigation
#10814 closed bug (fixed)
Opened November 17, 2011 03:18PM UTC
Closed September 06, 2013 03:29PM UTC
Last modified September 20, 2013 12:10AM UTC
make support as lazy as possible with closure in mind
| Reported by: | timmywil | Owned by: | m_gol |
|---|---|---|---|
| Priority: | high | Milestone: | 1.11/2.1 |
| Component: | support | Version: | 1.7 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
All of the support tests that run at doc ready, and possibly others, can instead be called lazily and then cached on jQuery.support. There are several advantages to this.
1. It makes page loads faster.
2. No doc ready needed
3. No invisible body needed
4. It is necessary for supporting Closure
Attachments (0)
Change History (13)
Changed November 17, 2011 03:19PM UTC by comment:1
| component: | unfiled → support |
|---|---|
| milestone: | None → 1.8 |
| owner: | → timmywil |
| priority: | undecided → blocker |
| status: | new → assigned |
Changed December 21, 2011 08:08AM UTC by comment:2
Do you imagine this would fix this bug I just reported? http://bugs.jquery.com/ticket/11082? I was calling jQuery.is(':visible') right after loading jQuery. The function started performing slowly, as it thought $.support.reliableHiddenOffsets was false; actually, the variable was undefined, as it hadn't been initialised at doc ready yet.
So, with a lazy solution, I imagine the first call to jQuery.is(':visible') would trigger the feature detect to set $.support.reliableHiddenOffsets?
Changed January 30, 2012 06:00PM UTC by comment:3
| owner: | timmywil → mikesherov |
|---|
Changed May 18, 2012 12:19AM UTC by comment:4
| milestone: | 1.8 → 1.next |
|---|---|
| priority: | blocker → high |
Changed October 22, 2012 04:52PM UTC by comment:5
| owner: | mikesherov |
|---|---|
| status: | assigned → open |
Changed December 28, 2012 01:45AM UTC by comment:6
It looks to me like there won't be much left of support.js once we've moved to 2.0, but I'll keep this open until our round of refactoring there.
Changed January 26, 2013 10:08PM UTC by comment:7
| milestone: | 1.next → 2.0 |
|---|---|
| resolution: | → fixed |
| status: | open → closed |
This is essentially done in 2.0; we can always improve it as we see opportunities.
Changed July 22, 2013 04:34PM UTC by comment:8
| milestone: | 2.0 |
|---|---|
| resolution: | fixed |
| status: | closed → reopened |
Changed July 22, 2013 04:35PM UTC by comment:9
| milestone: | → 2.next |
|---|---|
| owner: | → m_gol |
| status: | reopened → assigned |
I'm taking it over. I'll get to it as soon as timmywil's AMD branch is merged.
Changed July 22, 2013 09:18PM UTC by comment:10
| blocking: | → 14164 |
|---|
Changed September 06, 2013 03:29PM UTC by comment:11
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Fix #10814. Make support tests lazy and broken out to components.
Changeset: bbbdd947256a3fcd788fb9d4f306046082a1ef1f
Changed September 16, 2013 08:01PM UTC by comment:12
| blocking: | 14164 |
|---|
(In #14164) It's blocked by an open ticket, but it is probably better to handle the others on a case-by-case basis rather than a meta-ticket.
Changed September 20, 2013 12:10AM UTC by comment:13
| milestone: | 2.next → 1.11/2.1 |
|---|