Bug Tracker

Ticket #10794 (closed bug: fixed)

Opened 3 years ago

Last modified 2 years ago

.triggerHandler should not .preventDefault()

Reported by: dmethvin Owned by: dmethvin
Priority: high Milestone: 1.7.1
Component: event Version: 1.7
Keywords: Cc:
Blocking: Blocked by:

Description

Currently, .triggerHandler() calls event.preventDefault() to avoid the default action running. However, this prevents the caller from using the default action indication that might be returned by one of the handlers. Since we have an onlyHandlers variable we can use that instead and not mess with the event.

Change History

comment:1 Changed 3 years ago by dmethvin

  • Owner set to dmethvin
  • Priority changed from undecided to high
  • Status changed from new to assigned
  • Component changed from unfiled to event
  • Milestone changed from None to 1.7.1

comment:2 Changed 3 years ago by dmethvin

  • Blocking 10699 added

comment:3 Changed 3 years ago by Dave Methvin

  • Status changed from assigned to closed
  • Resolution set to fixed

Fix #10794. .triggerHandler() should not .preventDefault().

This also provides a resolution for #10699.

Changeset: 6736dd7168ccd1e6d72aca2e3c89d685c5d9c63a

comment:4 Changed 2 years ago by dmethvin

  • Blocking 10699 removed

(In #10699) @maranomynet, I closed this ticket because I thought we'd addressed the common use cases. If I am to interpret your snarky posts and tweets, we haven't addressed a use case that is important to you.

Can you describe your situation a bit more? Is there a reason why the handlers themselves cannot stop propagation?

Note: See TracTickets for help on using tickets.