Ticket #10691 (closed enhancement: fixed)
remove all occurrences of the "equals" and "same" function in the unit tests`
| Reported by: | mikesherov | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | 1.7.1 |
| Component: | misc | Version: | 1.7 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
in testrunner.js:
window.equals = window.equal; window.same = window.deepEqual;
it's time this aliases went bye bye. 1.8?
Change History
comment:1 Changed 20 months ago by rwaldron
- Status changed from new to open
- Component changed from unfiled to misc
- Priority changed from undecided to low
- Milestone changed from None to 1.8
- Keywords 1.8-discuss added
- Type changed from bug to enhancement
comment:2 Changed 20 months ago by mikesherov
Here's the pull request: https://github.com/jquery/jquery/pull/580
comment:3 Changed 20 months ago by dmethvin
Since there's a PR we should either land this ASAP or close the PR since it's going to get awfully stale.
comment:4 Changed 20 months ago by mikesherov
Yeah. I guess 1.7.1 then? I tested in FF and Chrome from a hosted copy (so isLocal was false and all tests ran). No reason this shouldnt work in other browsers.
comment:5 Changed 20 months ago by Mike Sherov
- Status changed from open to closed
- Resolution set to fixed
Fix #10691. Remove all instances of equals() and same(), as these are deprecated in QUnit.
Changeset: f35ba5e699c15a1987baa389dbd4fc99f7a7eb03
comment:7 Changed 20 months ago by gnarf
Thanks Mike - someone has needed to do this for quite a while now... Glad you took the initiative!
comment:9 Changed 20 months ago by mikesherov
Rick deserves the credit here. A midnight IRC convo with him caused the change. All I did was find and replace.
comment:10 Changed 20 months ago by rwaldron
Mike deserves the credit for actually doing the dirty work that no one else wanted to do ahaha
Please follow the bug reporting guidlines and use jsFiddle when providing test cases and demonstrations instead of pasting the code in the ticket.
+1 and Yay!