Side navigation
#10375 closed bug (fixed)
Opened September 29, 2011 03:13AM UTC
Closed September 29, 2011 02:35PM UTC
Do not include `type` in jQuery.event.props
| Reported by: | frankvmurphy@gmail.com | Owned by: | dmethvin |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.7 |
| Component: | event | Version: | 1.7b1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
The inclusion of type in the jQuery.event.props list will clobber the type that is set in jQuery.Event when it is passed through jQuery.event.fix()
Original ticket:
jQueryUI slider works well with latest 1.6
Sliding with mouse malfunctions.
Get "RangeError: Maximum call stack size exceeded. Line 4155"
On Safari,Chrome,Firefox
http://jsfiddle.net/3evgS/ (No 1.7b1 yet, but this should malfunction with it)
Attachments (0)
Change History (5)
Changed September 29, 2011 04:00AM UTC by comment:1
| _comment0: | Confirmed. This seems to be rooted in Sizzle. → 1317268923276542 |
|---|---|
| component: | unfiled → selector |
| milestone: | None → 1.7 |
| priority: | undecided → blocker |
| status: | new → open |
Changed September 29, 2011 04:03AM UTC by comment:2
| component: | selector → event |
|---|
Changed September 29, 2011 02:11PM UTC by comment:3
Changed September 29, 2011 02:15PM UTC by comment:4
| description: | jQueryUI slider works well with latest 1.6 \ Sliding with mouse malfunctions. \ Get "RangeError: Maximum call stack size exceeded. Line 4155" \ On Safari,Chrome,Firefox \ \ http://jsfiddle.net/3evgS/ (No 1.7b1 yet, but this should malfunction with it) → The inclusion of `type` in the `jQuery.event.props` list will clobber the type that is set in `jQuery.Event` when it is passed through `jQuery.event.fix()` \ \ \ Original ticket: \ \ jQueryUI slider works well with latest 1.6 \ Sliding with mouse malfunctions. \ Get "RangeError: Maximum call stack size exceeded. Line 4155" \ On Safari,Chrome,Firefox \ \ http://jsfiddle.net/3evgS/ (No 1.7b1 yet, but this should malfunction with it) |
|---|---|
| owner: | → dmethvin |
| status: | open → assigned |
| summary: | Stacksize exceeded on slider mouseevent → Do not include `type` in jQuery.event.props |
Changed September 29, 2011 02:35PM UTC by comment:5
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Fix #10375. Don't put type in jQuery.event.props
It's already set in jQuery.Event, and copying it can clobber values set by the caller, e.g., the UI widget factory.
Changeset: 96a44a86d870f2634c82a4148d22d0a07044ba77
Confirmed.