Side navigation
#10299 closed bug (fixed)
Opened September 17, 2011 11:41AM UTC
Closed November 19, 2012 10:10PM UTC
hrefNormalized === false also needs a propHook
| Reported by: | info@corrupt-system.de | Owned by: | rwaldron |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.9 |
| Component: | attributes | Version: | 1.6.4rc1 |
| Keywords: | ie6 ie7 | Cc: | |
| Blocked by: | Blocking: |
Description
jQuery always normalized the content attribute for href/src in IE6/7. Now we have prop and I think, jQuery should also normalize the href/-src-property.
In IE6/7 getting the href attribute should look like this (is already done by jQuery):
anchor.getAttribute('href', 2);
In IE6/7 getting the href property should look like this (should be done by jQuery):
anchor.getAttribute('href', 4);
I made a jsfiddle to document the problem:
http://jsfiddle.net/trixta/PH76V/
Please also have a look at the Microsoft documentation of getAttribute:
http://msdn.microsoft.com/en-us/library/ms536429%28VS.85%29.aspx
Attachments (0)
Change History (10)
Changed September 19, 2011 04:09PM UTC by comment:1
| component: | unfiled → attributes |
|---|---|
| owner: | → timmywil |
| status: | new → assigned |
Changed September 19, 2011 04:22PM UTC by comment:2
| owner: | timmywil → rwaldron |
|---|---|
| priority: | undecided → low |
@timmywil I haven't actually reviewed this issue or the fiddle
Changed March 03, 2012 09:18PM UTC by comment:3
| milestone: | None → 1.8 |
|---|
This ticket looks valid to me, seems like we need a propHook here. Given that it's for prehistoric browsers I'd be okay with inferring off the existing hrefNormalized detect rather than adding more code to support.js for it.
Changed June 26, 2012 01:52PM UTC by comment:4
| keywords: | → ie6 ie7 |
|---|
Changed August 10, 2012 05:48PM UTC by comment:5
| milestone: | 1.8 → 1.8.1 |
|---|---|
| priority: | low → blocker |
Changed August 27, 2012 02:01PM UTC by comment:6
| milestone: | 1.8.1 → 1.9 |
|---|
Changed November 02, 2012 12:51AM UTC by comment:7
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Fix #10299. Add a propHook for oldIE link href.
Changeset: 240b141a22c4783d619fc67c91f990d1535e7c57
Changed November 19, 2012 10:02PM UTC by comment:9
| resolution: | fixed |
|---|---|
| status: | closed → reopened |
The committed solution is invalid. The src and href attributes should return unaltered strings. We use getAttribute( "href", 2) to get the unaltered string. This should not be changed.
See the native behavior in a modern browser for support of what I'm talking about. http://jsbin.com/alebuq/1/
Changed November 19, 2012 10:10PM UTC by comment:10
| resolution: | → fixed |
|---|---|
| status: | reopened → closed |
Sorry, I have attributes on the mind.