Skip to main content

Bug Tracker

Side navigation

#10098 closed bug (fixed)

Opened August 19, 2011 04:50PM UTC

Closed August 25, 2011 07:17PM UTC

Last modified December 19, 2011 12:05PM UTC

Encode comment-like Accept headers to avoid mobile carrier mangling

Reported by: dmethvin Owned by: dmethvin
Priority: low Milestone: 1.6.3
Component: ajax Version: 1.6.2
Keywords: Cc:
Blocked by: Blocking:
Description

It's not our fault but we could easily put a fix in 1.6.3 to prevent the problem -- just encode the slash in the JavaScript string.

http://www.mysociety.org/2011/08/11/mobile-operators-breaking-content/

Attachments (0)
Change History (10)

Changed August 22, 2011 02:10AM UTC by dmethvin comment:1

milestone: None1.6.3

Changed August 22, 2011 06:03AM UTC by addyosmani comment:2

Totally agree with this being fixed. We've seen a number of tickets come through this year about carriers breaking jQuery due to further attempts at minification and I think the comments issue mentioned in the link Dave posted is common to most of them.

Changed August 22, 2011 01:14PM UTC by timmywil comment:3

component: unfiledajax
priority: undecidedlow
status: newopen

Changed August 23, 2011 02:40AM UTC by dmethvin comment:4

Here's the pull if we want to put this in:

https://github.com/jquery/jquery/pull/473

Either that, or close it wontfix and never speak of this again.

Changed August 25, 2011 02:41PM UTC by dmethvin comment:5

owner: → dmethvin
status: openassigned

Changed August 25, 2011 07:17PM UTC by Dave Methvin comment:6

resolution: → fixed
status: assignedclosed

Merge pull request #473 from dmethvin/fix-10098-faux-comment

Fixes #10098. Avoid a slashy-starry char sequence to prevent T-Mobile (and other brain-damaged) script compression breaking jQuery.

Changeset: 979dd1cb421a6880463f98842353461a0f1fae6e

Changed August 28, 2011 05:52PM UTC by dmethvin comment:7

#10153 is a duplicate of this ticket.

Changed November 02, 2011 02:35PM UTC by Markus.Staab comment:8

_comment0: we still encounter a JS Parse error over T-Mobile in Germany, when including jQuery.. doesn't matter if we use 1.6.3, 1.6.4 or the latest release candidate 1.7rc21320244846884674

we still encounter a JS Parse error over T-Mobile in Germany, when including jQuery.. doesn't matter if we use 1.6.3, 1.6.4 or the latest release candidate 1.7rc2

see http://s14.directupload.net/file/d/2696/ogrqu7jm_png.htm

Changed November 02, 2011 02:45PM UTC by dmethvin comment:9

@Markus, If you can identify the cause, for example by capturing the file as downloaded from T-Mobile and comparing it to an unmolested file, that would be helpful. This ticket is closed however; please don't add further comments. Create a new ticket with your findings if it appears that there is something we can do.

Changed December 19, 2011 12:05PM UTC by thingygeoff comment:10

This bug is still happening with certain mobile carriers. You can get round it by using the Google Hosted Code:

http://code.jquery.com/jquery-1.7.1.min.js