Bug Tracker

Opened 13 years ago

Closed 10 years ago

Last modified 8 years ago

#967 closed bug (invalid)

bug in plugin center

Reported by: agustin.garcia@… Owned by:
Priority: trivial Milestone:
Component: plugin Version:
Keywords: Cc:
Blocked by: Blocking:

Description (last modified by dmethvin)

My name's Agustin and I'm from Spain. I'm begining with jquery and I want tell you I find one bug in plugin "center".

With IE 6 and doctype XHTML this plugin not work. This a know problem,

look http://msdn.microsoft.com/workshop/author/dhtml/reference/properties/offsetheight.asp

Well, I propose this change:

if (window.innerHeight)

var clientHeight = window.innerHeight;

else if(document.body && document.body.offsetHeight)

var clientHeight = document.body.offsetHeight;

==ADD THIS LINE ===>>>>> if (document.body.offsetHeight == 0) clientHeight = document.documentElement.offsetHeight; /* arreglar doctype + xhtml en IE */

s.top = ((clientHeight - parseInt(jQuery.css(this,"height")))/2) + "px"; } else {

s.top = "0";

}

*

This work for me and I want share this, but dont know how. I love jquery. Thanks. Note: Excuse me my english.

Change History (2)

comment:1 Changed 13 years ago by anonymous

Sorry.

The line is /*-------------------------*/ if (clientHeight ==undefined) {clientHeight = document.documentElement.offsetHeight;} /* arreglar doctype + xhtml en IE */ /* -----------------------*/ Thanks

comment:2 Changed 10 years ago by dmethvin

Description: modified (diff)
need: Review
Resolution: invalid
Status: newclosed

This is not a jQuery core bug. Please report plugin bugs to the plugin's author, or ask on the jQuery forums. jQuery UI bugs should be reported on the UI bug tracker, http://dev.jqueryui.com .

Note: See TracTickets for help on using tickets.