animate function does't cast regex.exec() parameter to string before calling

Reported by:	Ryan	Owned by:	Ryan
Priority:	high	Milestone:	1.next
Component:	effects	Version:	1.6.1
Keywords:		Cc:
Blocked by:		Blocking:

Description

Occasionally an integer is passed to exec that causes the page to crash in IE when using XRegExp (the integer causes XRegExp's call of str.slice to produce an "Object doesn't support this property or method" error).

At first I thought it might be an XRegExp issue but the javascript docs clearly state that a string is expected. Converting the exec argument to a string prior to the call solves the problem.

Line 8159 is the culprit:

parts = rfxnum.exec( val );

should be changed to

parts = rfxnum.exec( val == null ? null : String(val) );

(Environment: 1.6.1 on IE 8 with Windows 7 using XRexExp 1.5)

Attachments (0)

Change History (6)

Changed June 14, 2011 12:13PM UTC by rwaldron comment:1

component:	unfiled → effects
owner:	→ rwaldron
priority:	undecided → high
status:	new → assigned

Changed June 14, 2011 02:03PM UTC by timmywil comment:2

Is there a test case for this showing the error?

Changed July 12, 2011 05:58PM UTC by rwaldron comment:3

owner:	rwaldron
status:	assigned → open

Changed July 12, 2011 05:59PM UTC by gnarf comment:4

owner:	→ Ryan
status:	open → pending

Can you get a test case / jsfiddle of this issue please?

Changed July 27, 2011 07:46AM UTC by trac-o-bot comment:5

resolution:	→ invalid
status:	pending → closed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Changed November 09, 2011 10:24PM UTC by anonymous comment:6

I get the same problem. Forcing string shoud resolve this issue:

parts = rfxnum.exec( String(val) );

Side navigation

#9575 closed bug (invalid)