Skip to main content

Bug Tracker

Side navigation

#9499 closed bug (fixed)

Opened June 02, 2011 06:05PM UTC

Closed June 08, 2011 01:03AM UTC

Last modified March 08, 2012 10:10PM UTC

removeClass will only remove the first instance of a class

Reported by: theallan Owned by: timmywil
Priority: high Milestone: 1.6.2
Component: attributes Version: 1.6.1
Keywords: Cc:
Blocked by: Blocking:

I've just been debugging an issue in my software where adding and removing classes with addClass and removeClass were doing something slightly odd. I realised that while addClass will add multiple instances of a class to an element (fair enough, I've asked it to do that), removeClass will only remove the first instance of a class. I would have expected it to remove all instances of the given class (although this could be an incorrect assumption on my part). For example

$("#test1").addClass("disabled disabled");

alert("test1 class after addClass ='"+$("#test1").attr("class")+"'");


alert("test1 class after removeClass ='"+$("#test1").attr("class")+"'");

The first alert will give "disabled disabled" while the second alert gives "disabled". I had anticipated it just being an empty string.

Attachments (0)
Change History (5)

Changed June 02, 2011 06:08PM UTC by theallan comment:1

jsFiddle example:

Possibly similar to bug #6914.

Changed June 02, 2011 06:12PM UTC by rwaldron comment:2

component: unfiledattributes
owner: → rwaldron
priority: undecidedhigh
status: newassigned

@ajpiano and I agree: addClass should not allow you to add the same class twice

Changed June 08, 2011 12:53AM UTC by timmywil comment:3

milestone: 1.next1.7
owner: rwaldrontimmywil

Changed June 08, 2011 01:00AM UTC by timmywil comment:4


Changed June 08, 2011 01:03AM UTC by timmywil comment:5

resolution: → fixed
status: assignedclosed

Check classes passed for duplicates. Fixes #9499.

Changeset: db437be6e31c924aade13bb719f9facc122b3d9c