Skip to main content

Bug Tracker

Side navigation

#9401 closed enhancement (wontfix)

Opened May 22, 2011 07:22PM UTC

Closed June 06, 2011 06:42PM UTC

Better Hooks Organization

Reported by: rwaldron Owned by:
Priority: low Milestone: 1.7
Component: core Version: 1.6.1
Keywords: Cc:
Blocked by: Blocking:

Is it too late to change all these "fooHooks" into something a little more organized, like...

Attachments (0)
Change History (14)

Changed May 22, 2011 07:28PM UTC by john comment:1

keywords: → 1.7-discuss

Nominating ticket for 1.7 discussion.

Changed May 22, 2011 08:09PM UTC by rwaldron comment:2


Changed May 23, 2011 01:09AM UTC by jaubourg comment:3


Changed May 23, 2011 04:32AM UTC by john comment:4

+1, Sounds great, as long as we keep the original hook points as well (maybe we can have special events in here as well?).

Changed May 23, 2011 05:13AM UTC by timmywil comment:5


Changed May 23, 2011 05:09PM UTC by comment:6

-1, straight up yak shaving. no benefit to users. (I don't think anyone will be iterating over all hooks)

Changed May 23, 2011 05:15PM UTC by rwaldron comment:7 the proposal isn't meant to directly benefit the users, it's primarily for improving maintenance and organization of internal code.

Changed May 23, 2011 11:57PM UTC by timmywil comment:8

component: unfiledcore
priority: undecidedlow
status: newopen

Changed May 24, 2011 10:35PM UTC by dmethvin comment:9

-1, This seems like rearranging the sock drawer to me, is there any pro to balance the con of going back and fixing all the existing code?

Changed June 04, 2011 10:15PM UTC by addyosmani comment:10


Changed June 05, 2011 10:04PM UTC by ajpiano comment:11

+0, It seems like all these "fooHooks" are just kind of ugly looking, but on the other hand, at least they give primacy to the thing that's being manipulated - "css" comes before "hooks" - whereas with the object of jQuery.hooks, there's just this abstract concept of "hooks" - which most people thought jQuery had long before we ever had any. (Heard the phrase "jQuery hooks into the document ready event" recently enough?) So it kind of makes it more confusing for people who need to use it, but yeah, it certainly is less than "appealing" as is...

Changed June 06, 2011 02:52PM UTC by danheberden comment:12


Changed June 06, 2011 03:48PM UTC by scottgonzalez comment:13

-1, I fail to see how this is any more organized

Changed June 06, 2011 06:42PM UTC by rwaldron comment:14

keywords: 1.7-discuss
milestone: 1.next1.7
resolution: → wontfix
status: openclosed