Opened 12 years ago
Closed 12 years ago
#9401 closed enhancement (wontfix)
Better Hooks Organization
Reported by: | Rick Waldron | Owned by: | |
---|---|---|---|
Priority: | low | Milestone: | 1.7 |
Component: | core | Version: | 1.6.1 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
Is it too late to change all these "fooHooks" into something a little more organized, like... https://gist.github.com/973761
Change History (14)
comment:1 Changed 12 years ago by
Keywords: | 1.7-discuss added |
---|
comment:4 Changed 12 years ago by
+1, Sounds great, as long as we keep the original hook points as well (maybe we can have special events in here as well?).
comment:6 Changed 12 years ago by
-1, straight up yak shaving. no benefit to users. (I don't think anyone will be iterating over all hooks)
comment:7 Changed 12 years ago by
@paul.irish the proposal isn't meant to directly benefit the users, it's primarily for improving maintenance and organization of internal code.
comment:8 Changed 12 years ago by
Component: | unfiled → core |
---|---|
Priority: | undecided → low |
Status: | new → open |
comment:9 Changed 12 years ago by
-1, This seems like rearranging the sock drawer to me, is there any pro to balance the con of going back and fixing all the existing code?
comment:11 Changed 12 years ago by
+0, It seems like all these "fooHooks" are just kind of ugly looking, but on the other hand, at least they give primacy to the thing that's being manipulated - "css" comes before "hooks" - whereas with the object of jQuery.hooks, there's just this abstract concept of "hooks" - which most people thought jQuery had long before we ever had any. (Heard the phrase "jQuery hooks into the document ready event" recently enough?) So it kind of makes it more confusing for people who need to use it, but yeah, it certainly is less than "appealing" as is...
comment:14 Changed 12 years ago by
Keywords: | 1.7-discuss removed |
---|---|
Milestone: | 1.next → 1.7 |
Resolution: | → wontfix |
Status: | open → closed |
Nominating ticket for 1.7 discussion.