Bug Tracker

Opened 8 years ago

Last modified 7 years ago

#9384 closed feature

jQuery.fx.interval should be replaced by an 'animation-tick' throttling feature. — at Version 13

Reported by: louisremi@… Owned by: lrbabe
Priority: low Milestone: None
Component: effects Version: 1.6.1
Keywords: 1.9-discuss Cc:
Blocked by: Blocking:

Description (last modified by mikesherov)

jQuery.fx.interval should be replaced by an 'animation-tick' throttling feature. Why removing fx.interval?

Why throttling animation ticks instead?

  • because it serves a similar purpose (saving CPU cycles when animations do not need to run at 60fps)
  • because it can solves all of the above problems
  • because the implementation adds only 1 line of code: https://github.com/jquery/jquery/pull/334/files

Change History (13)

comment:1 Changed 8 years ago by john

Keywords: 1.7-discuss added

Nominating ticket for 1.7 discussion.

comment:2 Changed 8 years ago by Rick Waldron

Description: modified (diff)

+0,

comment:3 Changed 8 years ago by jaubourg

+1, Agreed

comment:4 Changed 8 years ago by timmywil

+1, do it :)

comment:5 Changed 8 years ago by timmywil

Component: unfiledeffects
Description: modified (diff)
Priority: undecidedlow
Status: newopen

comment:6 Changed 8 years ago by dmethvin

+0, That commit has more than one line of code. Also, it changes the documented jQuery.fx.interval behavior. What docs changes do we need on this?

comment:7 Changed 8 years ago by john

Description: modified (diff)

+1, I think this is fine. Good to get consistency.

comment:8 Changed 8 years ago by ajpiano

Description: modified (diff)

+1

comment:9 Changed 8 years ago by scottgonzalez

Description: modified (diff)

+0

comment:10 Changed 8 years ago by lrbabe

Description: modified (diff)
Milestone: 1.next1.7
Owner: set to lrbabe
Status: openassigned

comment:11 Changed 8 years ago by timmywil

pull request from lrbabe

comment:12 Changed 8 years ago by dmethvin

Keywords: 1.8-discuss added; 1.7-discuss removed
Milestone: 1.71.8

Pushed to 1.8 since requestAnimationFrame was removed in 1.6.3 and it should be addressed as part of a larger animation reorganization.

comment:13 Changed 8 years ago by mikesherov

Description: modified (diff)

+1

Note: See TracTickets for help on using tickets.