Skip to main content

Bug Tracker

Side navigation

#922 closed bug (fixed)

Opened February 06, 2007 01:17PM UTC

Closed April 29, 2007 06:45PM UTC

Last modified June 21, 2007 04:10AM UTC

Fix Strict Warnings

Reported by: jamie{dot}mason{at}b Owned by:
Priority: minor Milestone: 1.1.3
Component: core Version: 1.1.2
Keywords: strict Cc:
Blocked by: Blocking:
Description

Very trivial, but it would be nice to fix the small strict warnings in jQuery which get in the way when looking for any of your own.

Error: t.substring is not a function

Line: 1

----------

Warning: anonymous function does not always return a value

Line: 1, Column: 225

Source code:

(c[j].apply(this,args)===false){event.preventDefault();event.stopPropagation();returnValue=false}}if(jQuery.browser.msie)event.target=event.preventDefault=event.stopPropagation=event.handler=event.data=null;return returnValue},fix:function(event){if(!even

----------

Warning: anonymous function does not always return a value

Line: 1, Column: 86

Source code:

lt=="even"&&num%2==0&&num>1&&cur==elem||result=="odd"&&num%2==1&&cur==elem)return cur}},sibling:function(n,elem){var r=[];for(;n;n=n.nextSibling){if(n.nodeType==1&&(!elem||n!=elem))r.push(n)}return r}});jQuery.event={add:function(element,type,handler,data

----------

Warning: anonymous function does not always return a value

Line: 1, Column: 53

Source code:

._resort)m=jQuery.expr[m[1]]._resort(m);return false}});if(m[1]==":"&&m[2]=="not")r=jQuery.filter(m[3],r,true).r;else if(m[1]=="."){var re=new RegExp("(^|\\s)"+m[2]+"(\\s|$)");r=jQuery.grep(r,function(e){return re.test(e.className||"")},not)}else{var f=jQ

----------

Warning: anonymous function does not always return a value

Line: 1, Column: 164

Source code:

on(e){return rec.test(e.className)});if(m[1]=="#"&&ret.length==1){var tmp=r;r=[];jQuery.each(tmp,function(){if(this.getAttribute("id")==m[2]){r=[this];return false}})}ret=r}t=t.replace(re2,"")}}if(t){var val=jQuery.filter(t,r);ret=r=val.r;t=jQuery.trim(va

----------

Warning: test for equality (==) mistyped as assignment (=)?

Line: 1, Column: 53

Source code:

1){target=this;a=0}var prop;while(prop=arguments[a++])for(var i in prop)target[i]=prop[i];return target};jQuery.extend({noConflict:function(){if(jQuery._$)$=jQuery._$;return jQuery},isFunction:function(fn){return!!fn&&typeof fn!="string"&&typeof fn[0]=="u

Attachments (0)
Change History (1)

Changed April 29, 2007 06:45PM UTC by john comment:1

milestone: → 1.1.3
need: → Review
priority: trivialminor
resolution: → fixed
status: newclosed
version: → 1.1.2

Fixed in SVN rev [1817].