Bay Area jQuery Conference T-Shirts do not follow the style guide.

[ralphholzmann]

Hello,

I attended the Bay Area jQuery Conference last weekend and was delighted to receive a stylish and high quality jQuery t-shirt. The front of the t-shirt says $("body").wrap(this);, while the back has the jQuery logo close to the top.

Upon further reflection, it dawned on me that the t-shirt does not follow the jQuery Core Style Guidelines. Per ​http://docs.jquery.com/JQuery_Core_Style_Guidelines#Function_Calls, it states "Always include extra spaces around the arguments." Considering that both the $ and wrap are function calls, the t-shirt should read $( "body" ).wrap( this );

This bug is a blocker for all future jQuery Conferences and I expect a patch to go out within the next couple of days. A sewable patch is preferred.

Thank you,

Ralph Holzmann

[miketaylr]

I can't reproduce, but I wasn't at the conference.

[Timmy Willison]

Actually, spaces are not required when double quotes are present (since they provide a visible space by themselves), so it would be

$("body").wrap( this );

[Rick Waldron]

Confirmed.

Additionally, throws an uncaught type error exception, see the test case:

​http://jsfiddle.net/rwaldron/RSdAg/

[dmethvin]

In the meantime, here is a workaround: Wear a size "Small" t-shirt and it will stretch to add some more space between the characters.

[Nikola]

Replying to dmethvin:

In the meantime, here is a workaround: Wear a size "Small" t-shirt and it will stretch to add some more space between the characters.

Confirmed, this works. It may not be pretty but it is functional.

[john]

Unfortunately the release is already out the door so it's a bit late. Let's bring this up during the next t-shirt roadmap discussion. In the meantime, patches welcome.

[anonymous]

saw this from twitter. Brilliant

[dougneiner]

The code did follow the style guide, but it was minified for production. We also recommend storing the shirts in a gzip-lock bag to keep the size small.

Additionally, after evaluating where this code would normally run, we realized we didn't need it to run in a closure. Unfortunately this means it is not compatible with jQuery running in .noConflict mode as $ is expected to equal jQuery. We do not recommend layering this shirt on top of a MooTools or Dojo shirt if possible. If you want to combine them, you will probably want to put the jQuery conference shirt on first.

[cowboy]

I'm going to release this revised t-shirt first as a plugin, and if you guys want me to add it into core, I have no problem with that. Just bring it up at the next roadmap meeting.

[Robert Katić]

No need to wait DOM ready - it is obviously a one page application, where tshirt was dynamically injected.

[jswartwood@…]

@rkatic, likely that guy in @cowboy's plugin snapshot is named Dominic... I would also recommend waiting for Dom ready before trying wrap. Otherwise he would not allow it I.e. "operation aborted".

[john]

Ok, we're closing bugs for 1.6, to make sure we have no blockers. We can have more fun later ;)