Bug Tracker

Opened 11 years ago

Closed 11 years ago

#873 closed bug (fixed)

Re-work Triggered Events

Reported by: john Owned by:
Priority: major Milestone: 1.2
Component: event Version: 1.1.4
Keywords: Cc:
Blocked by: Blocking:

Description (last modified by brandon)

This is how event triggering should be re-worked:

.trigger("event"):

  • Should be cancellable.
  • Should only trigger bound event handlers.

.triggerAction("event")

  • Should trigger default browser action
  • Should not be cancellable
  • Should not allow clicking on links in IE
  • If no action exists, call trigger("event")

.click()

  • Should use triggerAction

Change History (6)

comment:1 Changed 11 years ago by john

Description: modified (diff)
need: → Test Case
Summary: A triggered event can't be canceled with .preventDefault() → Re-work Triggered Events

comment:2 Changed 11 years ago by brandon

So .click() will only use triggerAction and will not use trigger at all?

comment:3 Changed 11 years ago by john

Correct - but triggerAction will call trigger if no default action exists. (Since default actions end up triggering the event handlers anyway.)

comment:4 Changed 11 years ago by brandon

Description: modified (diff)

A related ticket is #1192.

comment:5 Changed 11 years ago by julienw

I'd like to swap "trigger" and "triggerAction" in this description. otherwise, existing script that use "trigger" to trigger default browser actions would break ! :)

On the other hand, "triggerAction" would give a new feature... and that's exactly what your description of "trigger" is.

comment:7 Changed 11 years ago by john

Milestone: 1.1.3 → 1.2
Resolution: → fixed
Status: new → closed
Version: 1.1 → 1.1.4

Fixed in SVN rev [3008].

Note: See TracTickets for help on using tickets.