Skip to main content

Bug Tracker

Side navigation

#8488 closed bug (fixed)

Opened March 09, 2011 10:02PM UTC

Closed March 10, 2011 03:05AM UTC

Last modified March 14, 2012 06:21PM UTC

.toggle( showOrHide ) is not consistent with documentation

Reported by: kellyselden Owned by:
Priority: undecided Milestone:
Component: unfiled Version: 1.5.1
Keywords: Cc:
Blocked by: Blocking:

the documentation says it is the equivalent to

if (showOrHide) {
} else {

but if showOrHide = 1, toggle will not show it because it is checking for a boolean type at line 7498 in jquery 1.5.1

toggle: function( fn, fn2, callback ) {
    var bool = typeof fn === "boolean";

my simplified code looks something like this when i ran into the problem:

function toggleSection(show) {
    //bunch of stuff based on show


my work-around is to always remember to check against true

$('.something1').toggle(show == true);
Attachments (0)
Change History (1)

Changed March 10, 2011 03:05AM UTC by dmethvin comment:1

resolution: → fixed
status: newclosed

I've updated the docs to clarify the equivalent code to emphasize that it needs a Boolean argument or it won't match that particular API signature.