Opened 12 years ago
Closed 12 years ago
#8402 closed bug (fixed)
jQuery.cssProps is useless in all browsers but IE6/7/8
Reported by: | lrbabe | Owned by: | lrbabe |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | css | Version: | 1.5.1 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
jQuery.cssProps is an object in which you can "Add in properties whose names you wish to fix before setting or getting the value".
It is used by jQuery core to map the float property to "cssFloat" or "styleFloat" depending on the browser.
Unfortunately, the current implementation is not as generic as it is supposed to be: browsers implementing window.getComputedStyle will completely ignore the "fixed property" in jQuery.css(). It works well for the 'float' property but makes jQuery.cssProps useless for other properties.
It could be really useful to create basic cssHooks:
var vendorPrefixedTransform = detectFeature('transform'); jQuery.cssProps.transform = vendorPrefixedTransform;
Change History (8)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
Component: | unfiled → css |
---|---|
Owner: | set to lrbabe |
Status: | new → pending |
It sounds like you're actually describing cssHooks - can you confirm?
comment:3 Changed 12 years ago by
Status: | pending → new |
---|
Nope, I do not confirm. I should be able to use jquery.cssProps to make my cssHooks smaller and faster.
comment:4 Changed 12 years ago by
Status: | new → pending |
---|
We're not clear on what you are asking for here; can you explain further?
comment:5 Changed 12 years ago by
Status: | pending → new |
---|
Using jQuery.cssProps, I should be able to create tiny pseudo-cssHooks like so:
jQuery.cssProps.transform = "-webkit-transform";
This feature is described in the comments of the jQuery.cssProps object: "Add in properties whose names you wish to fix before setting or getting the value"
Unfortunately, the implementation is only half-baked and trying to access the computed style will fail. This patch fixes this problem. I'll add a unit-test asap.
comment:6 Changed 12 years ago by
unit-test added: https://github.com/jquery/jquery/pull/255/files#diff-1
comment:7 Changed 12 years ago by
New pull request is here: https://github.com/jquery/jquery/pull/316
comment:8 Changed 12 years ago by
Milestone: | 1.next → 1.6 |
---|---|
Priority: | undecided → high |
Resolution: | → fixed |
Status: | new → closed |
Landed.
see pull request: https://github.com/jquery/jquery/pull/255/files