Bug Tracker

Opened 5 years ago

Closed 5 years ago

#8402 closed bug (fixed)

jQuery.cssProps is useless in all browsers but IE6/7/8

Reported by: lrbabe Owned by: lrbabe
Priority: high Milestone: 1.6
Component: css Version: 1.5.1
Keywords: Cc:
Blocked by: Blocking:

Description

jQuery.cssProps is an object in which you can "Add in properties whose names you wish to fix before setting or getting the value".

It is used by jQuery core to map the float property to "cssFloat" or "styleFloat" depending on the browser.

Unfortunately, the current implementation is not as generic as it is supposed to be: browsers implementing window.getComputedStyle will completely ignore the "fixed property" in jQuery.css(). It works well for the 'float' property but makes jQuery.cssProps useless for other properties.

It could be really useful to create basic cssHooks:

var vendorPrefixedTransform = detectFeature('transform');
jQuery.cssProps.transform = vendorPrefixedTransform;

Change History (8)

comment:2 Changed 5 years ago by rwaldron

  • Component changed from unfiled to css
  • Owner set to lrbabe
  • Status changed from new to pending

It sounds like you're actually describing cssHooks - can you confirm?

comment:3 Changed 5 years ago by lrbabe

  • Status changed from pending to new

Nope, I do not confirm. I should be able to use jquery.cssProps to make my cssHooks smaller and faster.

comment:4 Changed 5 years ago by dmethvin

  • Status changed from new to pending

We're not clear on what you are asking for here; can you explain further?

comment:5 Changed 5 years ago by lrbabe

  • Status changed from pending to new

Using jQuery.cssProps, I should be able to create tiny pseudo-cssHooks like so:

jQuery.cssProps.transform = "-webkit-transform";

This feature is described in the comments of the jQuery.cssProps object: "Add in properties whose names you wish to fix before setting or getting the value"

Unfortunately, the implementation is only half-baked and trying to access the computed style will fail. This patch fixes this problem. I'll add a unit-test asap.

comment:7 Changed 5 years ago by lrbabe

comment:8 Changed 5 years ago by john

  • Milestone changed from 1.next to 1.6
  • Priority changed from undecided to high
  • Resolution set to fixed
  • Status changed from new to closed

Landed.

Note: See TracTickets for help on using tickets.